holic75/kingmakerfavoredclass

This is Pathfinder: Kingmaker mod that adds various favored classes options

kingmakerfavoredclass's Issues

Mod Manager Log Errors

I'm currently running your latest version of CotW, Properflanking 2 and Favored Class mods, all under the latest version of the game.

When I load the game and the MM Window pops up, under the logs heading I see these errors for your Flavored Class mod... Just reporting it here for you as I'm not sure what these are or if they will cause a problem with my game.

[ZFavoredClass] Loading favored class bonus from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/Custom/bonus_charmed_life.json
[ZFavoredClass] Failure
[ZFavoredClass] System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.Collections.Generic.Dictionary2[TKey,TValue].get_Item (TKey key) [0x0001e] in <7ba07f088431485bb722f3b3373e87ee>:0 at CallOfTheWild.ExtensionMethods.Get[T] (Kingmaker.Blueprints.LibraryScriptableObject library, System.String assetId) [0x00006] in <55e6e40757994262ac7e937d0570dab1>:0 at ZFavoredClass.Core.loadCustomFeature (System.String filename) [0x000ef] in <3efd38e786824b4d8d53e368a3664919>:0 [ZFavoredClass] Loading favored class bonus from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/Custom/bonus_panache.json [ZFavoredClass] Failure [ZFavoredClass] System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary. at System.Collections.Generic.Dictionary2[TKey,TValue].get_Item (TKey key) [0x0001e] in <7ba07f088431485bb722f3b3373e87ee>:0
at CallOfTheWild.ExtensionMethods.Get[T] (Kingmaker.Blueprints.LibraryScriptableObject library, System.String assetId) [0x00006] in <55e6e40757994262ac7e937d0570dab1>:0
at ZFavoredClass.Core.loadCustomFeature (System.String filename) [0x000ef] in <3efd38e786824b4d8d53e368a3664919>:0
[ZFavoredClass] Loading favored class bonus from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/Custom/channel_energy_bonus.json
[ZFavoredClass] Success
[ZFavoredClass] Loading favored class bonus from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/Custom/druid_wildshape_natural_ac_bonus.json
[ZFavoredClass] Success
[ZFavoredClass] Loading favored class bonus from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/Custom/fervor_bonus.json
[ZFavoredClass] Success
[ZFavoredClass] Loading favored class bonus from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/Custom/harm_undead_bonus.json
[ZFavoredClass] Success
[ZFavoredClass] Loading favored class bonus from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/Custom/patron_spells_bonus.json
[ZFavoredClass] Success
[ZFavoredClass] Loading favored class bonus from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/Custom/spiritualist_bonded_manifestation.json
[ZFavoredClass] Success
[ZFavoredClass] Loading favored class bonus from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/Custom/spiritualist_inference_bonus.json
[ZFavoredClass] Success
[ZFavoredClass] Loading prestigious spellcaster data from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/PrestigiousSpellcaster/arcane_archer.json
[ZFavoredClass] Failure
[ZFavoredClass] System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
at System.Collections.Generic.Dictionary2[TKey,TValue].get_Item (TKey key) [0x0001e] in <7ba07f088431485bb722f3b3373e87ee>:0 at CallOfTheWild.ExtensionMethods.Get[T] (Kingmaker.Blueprints.LibraryScriptableObject library, System.String assetId) [0x00006] in <55e6e40757994262ac7e937d0570dab1>:0 at ZFavoredClass.Core.loadPrestigiousSpellCaster (System.String filename) [0x000f5] in <3efd38e786824b4d8d53e368a3664919>:0 [ZFavoredClass] Loading prestigious spellcaster data from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/PrestigiousSpellcaster/dawnflower_anchorite.json [ZFavoredClass] Success [ZFavoredClass] Loading prestigious spellcaster data from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/PrestigiousSpellcaster/deadeye_devotee.json [ZFavoredClass] Failure [ZFavoredClass] System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary. at System.Collections.Generic.Dictionary2[TKey,TValue].get_Item (TKey key) [0x0001e] in <7ba07f088431485bb722f3b3373e87ee>:0
at CallOfTheWild.ExtensionMethods.Get[T] (Kingmaker.Blueprints.LibraryScriptableObject library, System.String assetId) [0x00006] in <55e6e40757994262ac7e937d0570dab1>:0
at ZFavoredClass.Core.loadPrestigiousSpellCaster (System.String filename) [0x000f5] in <3efd38e786824b4d8d53e368a3664919>:0
[ZFavoredClass] Loading prestigious spellcaster data from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/PrestigiousSpellcaster/dragon_disciple.json
[ZFavoredClass] Success
[ZFavoredClass] Loading prestigious spellcaster data from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/PrestigiousSpellcaster/eldritch_knight.json
[ZFavoredClass] Success
[ZFavoredClass] Loading prestigious spellcaster data from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/PrestigiousSpellcaster/hinterlander.json
[ZFavoredClass] Success
[ZFavoredClass] Loading prestigious spellcaster data from: D:\Steam\steamapps\common\Pathfinder Kingmaker\Mods/ZFavoredClass/PrestigiousSpellcaster/holy_vindicator.json
[ZFavoredClass] Success
[ZFavoredClass] Enabling deity selection for everyone.
[ZFavoredClass] Enabling Traits.

[Bug] Bonus Skill Points When Playing Human

Tested on a character with "Call of the Wild" and "Favoured Class" active. When playing a Human character, choosing "Bonus Skill Points" NEVER adds a bonus skill point, no matter how many times you select it. Tested on a Human Druid and Storm Druid with 12 Intelligence, and I always got 5 skill points per level.

Earth Element Damage Bonus not applied

The dwarf favoured class option for the Kineticist to get +1/3 damage on earth element blasts that apply your Elemental Overflow bonus simply does not apply. I've tested it at both level 3 and 6, both with and without burn, and with both pure Earth and the composite Mud blasts, and with and without balance fixes. I end up with my base damage (1/2 level rounded up+constitution), plus my elemental overflow, but nothing more. From my understanding, since I've taken the bonus every level, I should have an extra +2 damage with my earth elemental blasts. This happens in version 2.15d, with only Call of the Wild, Favored Class, and Bag of Tricks for testing.

Remaining mod path dir issues

I'm still encountering some new mod path issues with the recent fix, cc94dab . I noticed the following two locations aren't using UMM's API to get the Mods directory:

KingmakerFavoredClass/ZFavoredClass/Core.cs

Line 722 in cc94dab

string[] filePaths = Directory.GetFiles(@"./Mods/ZFavoredClass/Custom/", "*.json", SearchOption.TopDirectoryOnly);

KingmakerFavoredClass/ZFavoredClass/Core.cs

Line 742 in cc94dab

string[] filePaths = Directory.GetFiles(@"./Mods/ZFavoredClass/PrestigiousSpellcaster/", "*.json", SearchOption.TopDirectoryOnly);

---

From #2 :

It looks like the Custom favored classes fails to load due to the same issue.

[ZFavoredClass] System.IO.DirectoryNotFoundException: Could not find a part of the path '/home/user/gamesdata/GOG Games/Pathfinder Kingmaker/game/Mods/ZFavoredClass/Custom'.
  at System.IO.__Error.WinIOError (System.Int32 errorCode, System.String maybeFullPath) [0x000f7] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.FileSystemEnumerableIterator`1[TSource].HandleError (System.Int32 hr, System.String path) [0x00006] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.FileSystemEnumerableIterator`1[TSource].CommonInit () [0x00054] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.FileSystemEnumerableIterator`1[TSource]..ctor (System.String path, System.String originalUserPath, System.String searchPattern, System.IO.SearchOption searchOption, System.IO.SearchResultHandler`1[TSource] resultHandler, System.Boolean checkHost) [0x000d6] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.FileSystemEnumerableFactory.CreateFileNameIterator (System.String path, System.String originalUserPath, System.String searchPattern, System.Boolean includeFiles, System.Boolean includeDirs, System.IO.SearchOption searchOption, System.Boolean checkHost) [0x00009] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.Directory.InternalGetFileDirectoryNames (System.String path, System.String userPathOriginal, System.String searchPattern, System.Boolean includeFiles, System.Boolean includeDirs, System.IO.SearchOption searchOption, System.Boolean checkHost) [0x00000] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.Directory.InternalGetFiles (System.String path, System.String searchPattern, System.IO.SearchOption searchOption) [0x00000] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.Directory.GetFiles (System.String path, System.String searchPattern, System.IO.SearchOption searchOption) [0x00038] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at ZFavoredClass.Core.loadCustomFavoredClassBonuses () [0x00000] in <4e8f0f1a8035491e931a4fb2f6d089d6>:0 
  at ZFavoredClass.Core.load () [0x00594] in <4e8f0f1a8035491e931a4fb2f6d089d6>:0 
  at ZFavoredClass.Main+LibraryScriptableObject_LoadDictionary_Patch.Postfix (Kingmaker.Blueprints.LibraryScriptableObject __instance) [0x00037] in <4e8f0f1a8035491e931a4fb2f6d089d6>:0 
  at System.IO.__Error.WinIOError (System.Int32 errorCode, System.String maybeFullPath) [0x000f7] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.FileSystemEnumerableIterator`1[TSource].HandleError (System.Int32 hr, System.String path) [0x00006] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.FileSystemEnumerableIterator`1[TSource].CommonInit () [0x00054] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.FileSystemEnumerableIterator`1[TSource]..ctor (System.String path, System.String originalUserPath, System.String searchPattern, System.IO.SearchOption searchOption, System.IO.SearchResultHandler`1[TSource] resultHandler, System.Boolean checkHost) [0x000d6] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.FileSystemEnumerableFactory.CreateFileNameIterator (System.String path, System.String originalUserPath, System.String searchPattern, System.Boolean includeFiles, System.Boolean includeDirs, System.IO.SearchOption searchOption, System.Boolean checkHost) [0x00009] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.Directory.InternalGetFileDirectoryNames (System.String path, System.String userPathOriginal, System.String searchPattern, System.Boolean includeFiles, System.Boolean includeDirs, System.IO.SearchOption searchOption, System.Boolean checkHost) [0x00000] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.Directory.InternalGetFiles (System.String path, System.String searchPattern, System.IO.SearchOption searchOption) [0x00000] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at System.IO.Directory.GetFiles (System.String path, System.String searchPattern, System.IO.SearchOption searchOption) [0x00038] in <e1a80661d61443feb3dbdaac88eeb776>:0 
  at ZFavoredClass.Core.loadCustomFavoredClassBonuses () [0x00000] in <4e8f0f1a8035491e931a4fb2f6d089d6>:0 
  at ZFavoredClass.Core.load () [0x00594] in <4e8f0f1a8035491e931a4fb2f6d089d6>:0 
  at ZFavoredClass.Main+LibraryScriptableObject_LoadDictionary_Patch.Postfix (Kingmaker.Blueprints.LibraryScriptableObject __instance) [0x00037] in <4e8f0f1a8035491e931a4fb2f6d089d6>:0 

Consider fixing this and similar path issues related to not using UMM's mod dir api.

Any way to remove the race restrictions?

This is not a bug or anything, I just don't know an easier way to contanct the developer. Is there any way to remove the race restrictions on all the different bonuses? Or can you reccomend some software so I try to change it myself?

Aeromantic Affinity trait behavior issue

Aeromantic Affinity does not grant the CL bonus for spells, which had their type/descriptor changed to electricity, via Elemental Bloodline Arcana - Air.
Tested on the 2.1.5d build, using Shocking Grasp to verify that the trait functions for spells that meet the conditions by default. And by using Burning Hands to test if it works with the conversion mechanism.