homebridge-edomoticz

[homebridge]

homebridge-edomoticz

[oznu]

Hi @DewGew,

I just want to check the project owner, @PatchworkBoy, is happy for this to happen?

[PatchworkBoy]

Go for it... 👍

[oznu]

• - The plugin must successfully install.
• - The plugin must impliment the Homebridge Plugin Settings GUI.
• - The plugin must not start unless it is configured.
• - The plugin must not execute postinstall scripts that modify the users system in any way.
• - The plugin must not contain any analytics or calls that enable you to track the user.
• - The plugin must not throw unhandled exceptions, the plugin must catch and log it's own errors.
• - The plugin must be published to npm and the source code available on GitHub.
• - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
• - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
• - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

---

The plugin must not throw unhandled exceptions, the plugin must catch and log it's own errors.

If the plugin is misconfigured the following unhanlded exception is raised which kills Homebridge:

[4/5/2020, 10:38:01] [Domoticz] Initializing eDomoticz platform...
[4/5/2020, 10:38:01] TypeError: Cannot read property 'indexOf' of undefined
    at new eDomoticzPlatform (/usr/local/lib/node_modules/homebridge-edomoticz/index.js:107:21)
[4/5/2020, 10:38:01] Got SIGTERM, shutting down Homebridge...

Config errors should be caught and logged explaining what the issue is.

---

Everything else looks good 😄

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[DewGew]

@oznu any suggestions to fix this issue?

[oznu]

Extending the try...catch block to cover the part where the error is thrown should do it:

https://github.com/PatchworkBoy/homebridge-edomoticz/blob/master/index.js#L107

[DewGew]

somthing like this maybe:

try {
        this.server = config.server;
        this.authorizationToken = false;
        if (this.server.indexOf(":") > -1 && this.server.indexOf("@") > -1) {
            var tmparr = this.server.split("@");
            this.authorizationToken = Helper.Base64.encode(tmparr[0]);
            this.server = tmparr[1];
        }
        this.ssl = (config.ssl == 1);
        this.port = config.port;
        this.room = config.roomid;
        this.api = api;
        this.apiBaseURL = "http" + (this.ssl ? "s" : "") + "://" + this.server + ":" + this.port + "/json.htm?";
        this.mqtt = false;
    } catch (e) {
        return;
    }

[oznu]

Yeah, maybe log the error with log.error

[DewGew]

Now merged

[oznu]

Thanks!