homoelectromagneticus/yocto_808

Unofficial Firmware for a TR-808 Clone by E-Licktronic

yocto_808's Issues

Mute status is cleared (in stop mode) when switching between Edit and "DinSync" mode

When the Yocto is stopped and in Edit mode and there are some muted instruments, getting back to "DinSync" mode (needs to be done to restart it, otherwise it won't sync/play) automatically clears the mute status for all instruments.
This should not happen.

Pushing multiple step buttons during pattern edit mode doesn't work

While editing a pattern, a user is only able to edit one pattern step at a time. Pushing multiple step buttons at once does not make multiple simultaneous changes to the edited pattern.

Decide on coding style

The current source code is a mix of different coding styles.. This does not help with readability.
for example we have:

bla() { 
  // code
}

and also

bla () 
{
  // code
}

Not to mention very inconsistent use of spaces

I'd love to do a quick automated reformat of all the code at once, but I don't want to make the decision on my own. Personally coming from a PHP past, the first way is more natural to me, but I think generally the 2nd is used more for C code.. What to choose?

Slaving to external MIDI Transport messages, then going in Edit mode, stop from external and not sending any external tempo anymore and press Start button make the sequencer unable to be internally clocked anymore in Pattern Play mode.

Sorry for the long title.

It seems related to a behavior/feature? that when having slaved the sequencer transport from an external MIDI Clock with the MIDI Slave mode, the Edit mode becomes slaved to the external MIDI Clock and pressing Start, Stop and Start again doesn't reset to the beginning of the pattern but continue where it stopped, as if it was a MIDI Continue message.

Personally I can't see the benefit of this and if it's a feature, I can't see why it's not available when using the internal clock. So I would suggest to get rid of it as it can produce the simili bug mentionned in the title.

EDIT: even more annoying when having Edit mode becoming slaved to external MIDI Clock and pressing Start and Stop, then sending a Start message from an external source... it will also act as continue. So it's more like that in Edit mode while clock is being slaved to external MIDI clock, the Stop button will act as "pause".

Roll mode in MIDI slave mode does not play in time with the sync'd BPM

When using roll mode while the Yocto is a MIDI slave, the rolled drum hits are not in time with the master MIDI clock.

Code appears to support accent over MIDI, but there's no documentation

The MIDI expander mode appears to support triggering accent based on the velocity of an incoming MIDI note, but this is not documented or tested. It would be good to test and document this "hidden" feature if it indeed works.

Midi Sync + Pattern Edit + Encoder push bug

While synced to midi in pattern edit mode, when you push the encoder (to "clear" the notes of the current instrument), the tempo will desync severely

Track mode needs (sync) rework

While the pattern modes have been updated and contain a completely new way of doing sync, the track modes were left untouched. This will lead to unexpected behaviour and possibly bugs when switching from Pattern to Track or Track to Pattern.

Documentation is missing for how to use the triggers over MIDI

There is code that supports this, but it's not a documented feature!

Stop bar follow when length > 16 steps

Hi.
It's quite annoying to have the pattern follow the bars/steps when it's longer than 16 steps. It is quite difficult and annoying trying to enter the correct steps.
Would be great to have this feature disabled by default and enabled with some key combination.
Thanks for looking into this!
Flavio.

Not enough resolutions in Roll Mode

When the Yocto is in roll mode, the user cannot roll and instrument slowly (quarter notes or less).

[Expander mode] BD sound change if it's not the only one triggered at a time

Try to send a sequence to the Yocto in expander mode in which the BD sometimes is alone and sometimes is triggered at the same time as another instrument. Then keep only the BD volume turned on, you should hear that its sound changes depending if it's triggered alone or not.

Also it can be noted that the Accent slot can also be set up to be triggable by an external MIDI note but this won't produce any result, while will still impact the issue described above the same.

Roll mode in Pattern Play mode after starting the sequencer from MIDI slave mode is slightly bugged

The time division selection with the Tempo encoder works in a bad way.

No error handling on communications with the I2C EEPROM

Currently, no error handling exists for communications between the Yocto's EEPROM and micro. This means that if the ATMEGA1284 gets an unexpected NAK from the EEPROM, or if the ATMEGA1284 receives fewer bytes during a sequential read than it expected, stuff breaks and the user has no idea that something has gone wrong.

Even the most basic error handling (re-trying, etc) would be useful here.

Time Window To Issue Firmware Update Over MIDI Is Too Short

There is only a five second window after starting the Yocto in "update mode" to start sending the update. This is a bit too short of a window in many cases.

Trigger 2 does not work

Trigger 2 is not outputting standard V-Trig pulses per the Yocto's original specification. At first glance, the Trigger looks more like the "S-Trig" standard. What's worrying is that the output pulses are not correlated to what's programmed into the Trigger 2 pattern. The exact behavior is a bit different when the Yocto is in different modes, which points to a software problem. Additional discussion at http://www.e-licktronic.com/forum/viewtopic.php?f=17&t=1519.

Unable to activate trigger outputs during roll mode

The two trigger outputs are not able to be rolled like the other instruments.

Timing in MIDI expander mode is not tight

More details at [http://www.e-licktronic.com/forum/viewtopic.php?f=17&t=1275](the e-licktronic forum).