honestcheng/hessian-client

a simple hessian client, wrap the hessian.js, for personal use,only support hessian v1 now

hessian-client's Issues

Request tries to 'stringify' the binary content which can lead to incorrect data being processed.

While using this library I have encountered weird 0xef, 0xbf, 0xbd sequences where a single byte value should be present. After a lot of digging I have found the issue is in the request call. Without encoding: null the request returns a decoded-string which is then re-encoded to ByteArray.

Patch to fix this issue:

diff --git a/hessian.coffee b/hessian.coffee
index ced78ce..9b47b17 100644
--- a/hessian.coffee
+++ b/hessian.coffee
@@ -21,14 +21,14 @@ class HessianClient
                        buf

                parse_response= (res_data) ->
-                       buf = new Buffer res_data
-                       hessianjs.decode(buf[3..-1])
+                       hessianjs.decode(res_data[3..-1])


                option =
                        url: @url
                        headers: {'Content-Type': 'application/binary'}
                        method: 'POST'
+                       encoding: null
                        body: build_post_data(method, args)

                cb = (error, res, body) ->
diff --git a/hessian.js b/hessian.js
index d95e42a..f52b163 100644
--- a/hessian.js
+++ b/hessian.js
@@ -28,9 +28,7 @@
         return buf;
       };
       parse_response = function(res_data) {
-        var buf;
-        buf = new Buffer(res_data);
-        return hessianjs.decode(buf.slice(3));
+        return hessianjs.decode(res_data.slice(3));
       };
       option = {
         url: this.url,
@@ -38,6 +36,7 @@
           'Content-Type': 'application/binary'
         },
         method: 'POST',
+        encoding: null,
         body: build_post_data(method, args)
       };
       cb = function(error, res, body) {