hookercookerman/active_model_version_serializers

Versioning For ActiveModel::Serializer

active_model_version_serializers's Issues

How can I do versioning dynamic?

Hi,

I'm using a namespaced route to version my API:

namespace :api do
    namespace :v1 do
    end
end

I already configured my Serializer with this gem but the documentation is not clear enough and I don't know where to specify the serializer version dynamically.

I want them to load the right version based on the namespace 'v1, v2...'. How can I do that?

Anyone get this working on Heroku?

I have it working fine on my own dev box, and it responds with different versions just fine. When I push it to Heroku it's only using v1, even though v2 is the default.

Not sure if it's me or if there is Heroku caching issues. Anyone try that yet?

AMS root element configuration not respected

There is an issue when root element is configured this way :

ActiveSupport.on_load(:active_model_serializers) do
  # Disable for all serializers (except ArraySerializer)
  ActiveModel::Serializer.root = false
  # Disable for ArraySerializer
  ActiveModel::ArraySerializer.root = false
end

Actually the gem is doing that :

    def self.version(version, superclass = ActiveModel::Serializer, &block)
      base_class = self
      vklass = Class.new(superclass) do
        self.root(base_class._root)
        alias_method base_class._name.to_sym, :object

        singleton_class.class_eval do
          define_method(:to_s) do
            "(#{base_class.name} VERSION: #{version})"
          end
          alias inspect to_s
        end

It sets root (or not) directly based on parameters passed to the serializer :

[1] poc_api_app(#<Class>) »  superclass
=> ActiveModel::Serializer < Object
[2] poc_api_app(#<Class>) »  superclass._root?
=> false
[3] poc_api_app(#<Class>) »  base_class
=> UserSerializer < ActiveModel::VersionSerializer
[4] poc_api_app(#<Class>) »  base_class._root?
=> true

You can notice that it doesn't use my configuration and still includes the root element because it doesn't check if superclass._root? is false.