Hour Account > Minus hours calculations? > Not Approved OT Hours still shown

[borishinzer]

Hour Account > Minus hours calculations? > Not Approved OT Hours still shown

[horilla-opensource]

Hi @borishinzer ,
Currently we do not have this feature added in our system.
We are planning to adding it the upcoming updates.
Once done, we'll update you with it.
With Regards,
Team Horilla

[borishinzer]

Any update on this feature? IMO it would only be showing either overtimes or undertimes (minus hours) in hour account.

[CybroOdooDev]

Hi @borishinzer ,
Not presently.
We have it in our queue.
Sorry for the delay.
With Regards,
Team Horilla

[borishinzer]

Any update on this issue? This would be really awesome to integration as it would be our final issue (and fix for #54) to move completely to Horilla in favour of Kimai, which we used formerly.

[horilla-opensource]

Hi @borishinzer ,
We get your concern.
We'll get back to you with the solution to this by the end of this week.
Sorry for the delay to this.

With Regards,
Team Horilla

[horilla-opensource]

Hi @borishinzer ,
We have updated the hour calculation method.
Please check the commit
Please refer the video for the workflow.

Horilla.mp4

With Regards,
Team Horilla

[horilla-opensource]

Hi @borishinzer ,
Any updates on the above solution?

With Regards,
Team Horilla

[borishinzer]

Do I get this right?
Pending hours are "minus hours" (if the employee worked too few hours in one month / period).
Also, if the times are validated then they are taking into account, resulting in either overtimes or "pending hours"?

[horilla-opensource]

Hi @borishinzer ,
Yes, pending hours are considered as minus hours.
If attendance with pending hours are validated, then it is considered for the monthly account.
Similarly in the case of overtime. Only once approved, it'll be added to the accounts.

[borishinzer]

Cool. We are checking it for this for November. It would be good to show this column also to employees in the "My Attendances" .

[horilla-opensource]

Sure, will add that.

[horilla-opensource]

Hi @borishinzer ,
We have added the column for viewing the pending hours in My Attendances.

Please check.

With Regards,
Team Horilla

[borishinzer]

Awesome. Checking now our time tracking for November and will update the issue here.

[borishinzer]

Seems last update broke the validation somehow. I try to validate various entries, but they stay for validation.

[CybroOdooDev]

Are you getting any kind of error notifications or is it its just not getting validated even after clicking the validate button?

[borishinzer]

No error, time entry stays in tab "Validate Attandance". We even get a success message. Same behaviour under Actions.

[borishinzer]

Tried in Firefox incognito mode - issue stays the same. Where to find the logs?

[horilla-opensource]

Hi @borishinzer ,
Sorry for the delay.
We were able to reproduce the issue mentioned above from our side and we have made a fix for it.

Please check: [FIX] ATTENDANCE: Attendance validation issue

The issue was with the validation methods.
There was an existing request pending for that corresponding attendance. So on validating it was causing the issue.
In the new workflow user will be given a warning if there is an existing request pending prior to validation and user can view the corresponding request from that view where they will be able to approve it.

With Regards,
Team Horilla

[borishinzer]

Still not completely fixed. I get the request and then head over to "approve" the time entry, which doesn't change anything. If I "edit" and "save" the record without changing anything, it will get automatically approved.

[borishinzer]

You can find a video of the issue here: https://cloud.web-vision.de/index.php/s/oN7RMiNHXP4Fz7H

[borishinzer]

Additional: it seems that sometime "approval" is working and sometimes not.

[horilla-opensource]

Sure, we'll check and update the solution asap.

[horilla-opensource]

Still not completely fixed. I get the request and then head over to "approve" the time entry, which doesn't change anything. If I "edit" and "save" the record without changing anything, it will get automatically approved.

Hi @borishinzer ,
Could you check with the latest commits for the fix?

[borishinzer]

We didn't validate the time calculations yet, as we needed a full month of time trackings before. Our people are now actively testing Horilla based on the time trackings for November, December. Our aim is to report bugs and improvements and start using Horilla only (as substitute for Kimai) with beginning of November.

At this point I would like to says THANK YOU for your incredible work and your fast responses. This is really awesome 🙏

[horilla-opensource]

Hi @borishinzer ,
Thanks for taking your time in testing out Horilla and providing us with your suggestions to improve our system.
We are ready to assist you in all the support needed for setting up Horilla in your side.
Please feel free to contact us with any queries. ([email protected])

With Regards,
Team Horilla

[horilla-opensource]

Hi @borishinzer ,
Any updates on the issue fix?

With Regards,
Team Horilla

[borishinzer]

Still not working properly. I have validated all times of an employee and also approved his overtimes. Still the hour account shows wrong values and pending approvals.