horizontalsystems/ethereum-kit-android

Comprehensive EVM SDK (Ethereum, Binance Smart Chain, Avalanche, Arbitrum, Optimism, Polygon) for Android, implemented on Kotlin. Create wallets, watch wallets (read-only), sync transactions, filter transactions by type (erc20, bep20, swap transactions etc.), swap using native DEX protocols, connect to DeFi smart contracts using WalletConnect. Easily extendable to work with custom smart contracts. Full support for EIP1159.

ethereum-kit-android's Issues

Implement Setting gas price by priority

PeerGroup refactoring

• reimplement PeerGroup using TDD
• handle outgoing and incoming data correctly
• handle forks and block header sync (and validation)

Sending using ERC20 adapter uses wrong address and amount.

erc20kit/src/main/java/io/horizontalsystems/erc20kit/core/TransactionManager.kt

On line 40 it should be
return TransactionData(to = to, value = value, TransferMethod(to, value).encodedABI())

as it current overwrites the to address with the tokens contract address, and the value with 0.

Is there a reason why minsdk level is set to 26?

Due to the current situation, I have to set minsdk to 23.
I checked that build is possible in version 0.3.1, can I use this version?

I tried version 0.3.1 that can be built under minsdk 26, but there was an error.

The exception could not be delivered to the consumer because it has already canceled/disposed the flow or the exception has nowhere to go to begin with.

Cover LESPeer with unit tests and add additional connection layers

Use BlockchainState to store gasPrice and lastBlockHeight in database

Currently gasPrice and lastBlockHeight stored in separate tables

Add geth mobile aar as a module

In maven repo there is only old version org.ethereum:geth:1.8.11 available. Need to update it by downloading aar file and adding it manually.

Clear only DB related to wallet

Extract infuraApiKey to config

Cover DevP2PPeer with unit tests

Enable clients to switch between Etherscan and other public ETH block explorers

Enable users to switch between Etherscan and other public ETH block explorers on client side. This block explorer used to obtain transactions list for a given address.

[only After the release of the Bank Wallet version 1.0]

Extract all db related code into Storage class

Handle "Announce" messages

When "Announce" message is received,

• New block(s) must be downloaded from the peer
• New state must be requested and validated
• Peer's bestBlockHeight must be updated
• The following delegate methods should be called

IBlockchainDelegate#onUpdate(lastBlockHeight: Int)
IBlockchainDelegate#onUpdate(balance: String)
IBlockchainDelegate#onUpdate(syncState: SyncState)

Integrate Geth mobile

Ethereum project_id-project_secret-unique_wallet_id

Where will I get project_id , project_secret and unique_wallet_id?
I've create app on Infura and only got there api_key.
please guide me.

Implement Proof-of-Work validation

The algorithm is described in https://github.com/ethereum/wiki/wiki/Ethash

For more security spongycastle -> bouncycastle

For more security, can you change old spongycastle (based on old bouncycastle) to bouncycastle?

• https://www.bouncycastle.org/
• https://www.bouncycastle.org/releasenotes.html
• http://www.bouncycastle.org/latest_releases.html
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncy%20castle
• https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=bouncycastle
• https://www.cvedetails.com/vulnerability-list/vendor_id-7637/Bouncycastle.html

Some ERC20 Tokens incorrectly display the amount in transactions

Some ERC20 charge fee in tokens

Ex.: Stasis EURS for every transfer the contract collects arbitrary variable and fixed fee in EURS that will be deducted from your token balance in addition to the transferred amount.

At the moment: when i send this token, from my token balance deduct transferred Amount+ fixed fee in EURS, but in my transactions list I see only the amount of fee. It will be more correct to display 2 transactions: Transferred Amount and Fee in token

Update:

It should be taken into account that there is no standard for fee on ERC20 level. In other words, each ERC20 token may potentially have their own customized version of the fee on an ERC20 contract level. Therefore, whatever fix we apply it should be universal and work correctly for all such contracts.

Update gateway APIs

Extract erc20 to a separate kit

Custom token swipe is not working

My token address is 0x2c8aec2fd0c0feba71e0424873461908067d5bf4. when I swipe token from ETH to SHUBH (SHUBH), it show error pair is not found. but we have provide liquidity from SHUBH (SHUBH) to ETH in uniswape.

Support ERC20 tokens

Get rid of web3j dependency

Make sure EstimateGasJsonRpc can send 0 value

In iOS fix was made in EstimateGasJsonRpc. Make sure the same thing works in android

Integrate Requests to LESPeer for mapping responses to requests

Add transaction confirmation status

rewrite implementation to resemble Bitcoin kit

[only After the release of the Bank Wallet version 1.0]

Sometime Ethereum stuck in sync state(can spin forever). Only refresh helps.

Refactor transaction status in erc20 kit

func transactionStatus(transactionHash: Data) -> Single<TransactionStatus>
has useless transactionReceiptStatusSingle. transactionReceiptStatusSingle - is not valid for pending transactions.

We need to implement this sync the right way and use same approach for EthereumKit and Erc20Kit now these kits has different approach

Implement accelerate feature for eth based transactions

When transaction is stuck in pending state, user might need to rebroadcast it with same or higher fee.

To rebroadcast transaction use same nonce.

Add eth.sign or personal.sign Method

Add eth.sign or personal.sign Method
web3view

Core architecture refactoring

How to generate ETH Public Address

I've been poking around the ETH kit for a little while and I haven't come across a way to generate an ETH public address using the kit. If there isn't a way what's a workaround, and is there a possibility for the feature to be implemented? If there's already a way using the kit let me know. Thank you for your time!

No support for sepolia network

Add logger

ethereumkit/src/main/java/io/horizontalsystems/ethereumkit/network/MainNet.kt

Path : ethereumkit/src/main/java/io/horizontalsystems/ethereumkit/network/MainNet.kt

BlockHeader(hashHex = "bce9c39107fd4b58a31ab28975e4b5689a8a5e41d06b2736795cd6f643ac2d73".hexStringToByteArray(),
                    totalDifficulty = BigInteger("18601822522462629"),
                    parentHash = "c272ad832f06865beabc3dd4c83699e039740fba7239a0aa2c20c5ae434bec54".hexStringToByteArray(),
                    unclesHash = "1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347".hexStringToByteArray(),
                    coinbase = "cd626bc764e1d553e0d75a42f5c4156b91a63f23".hexStringToByteArray(),
                    stateRoot = "4f3513d052a8a85a7015359f17e9e61c4fc8169443017268500e09df991c0c55".hexStringToByteArray(),
                    transactionsRoot = "b82f3e93274ff1f68d10c7f6acef7d239794ae603e1a17f880793ed100f5be95".hexStringToByteArray(),
                    receiptsRoot = "6b1dfc93f7aa063b150605b05f6976c0d23159f7a27c708d9b7e9a8e19469199".hexStringToByteArray(),
                    logsBloom = "00000001000000000001000004000000002040000080000008000004000000000000000000000000000000000000000010044000002000000002000000000000010000000028000000008008800020000020000000808000800001080000000001000000020000000004000000000801000004000002400404000010000000000000010000000400000040000000000100000020000000000000000020020000000080200000000000002000000000000000000000000800000000000000000200000042000000000020000080000000008070810000040000000000000020080000000008000000000010200000020004000040000000000000000004000000".hexStringToByteArray(),
                    difficulty = ("ccc2825").hexStringToByteArray(),
                    height = 5227842,
                    gasLimit = "7a1200".hexStringToByteArray(),
                    gasUsed = 0x3161d0,
                    timestamp = 0x5c8f815b,
                    extraData = "d883010817846765746888676f312e31302e34856c696e7578".hexStringToByteArray(),
                    mixHash = ("cae580f260efcee4ed8789380528e9770b5c260d289321ff8c6352eb031d830").hexStringToByteArray(),
                    nonce = "004d35d804eac7d8".hexStringToByteArray())

Here coinbase = "cd626bc764e1d553e0d75a42f5c4156b91a63f23".hexStringToByteArray(),

What is the use of this in Ethereum Kit ? Just learning few things.
If a wallet user transfers some coins from one wallet to another using Unstoppable Ether Kit, does unstoppable wallet collect some fees ?

Remove GasPrice from Kit in Production

Database Migration : on wallet restore ERC20 tokens show balances from previous wallet

It looks like UNLINK FROM THIS DEVICE doesn't work correctly for ERC20 tokens

To reproduce:

1. download a new build and restore some wallet that has some ERC20 tokens with non-zero balance
2. unlink the wallet from device
3. restore some other wallet.
4. you will notice that balance s for erc20 tokens would be shown from previous wallet.

increase gas limit to 150000

There are a number of ERC20 tokens where 150000 gas limit seems insufficient to execute token transfer.

When that happens the transaction broadcasts to the network but the actual transfer fails due to insufficient gas limit. At the end user ends up paying current 100K gas limit but no transfer of tokens takes place.

Therefore we should increase gas limit to 150K.

App crashed on Unlink

PeerGroup: Closing all peer connections...
Process: io.horizontalsystems.bankwallet.dev, PID: 14364
    io.reactivex.exceptions.UndeliverableException: The exception could not be delivered to the consumer because it has already canceled/disposed the flow or the exception has nowhere to go to begin with. Further reading: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#error-handling | null
        at io.reactivex.plugins.RxJavaPlugins.onError(RxJavaPlugins.java:367)
        at io.reactivex.internal.operators.flowable.FlowableFromCallable.subscribeActual(FlowableFromCallable.java:43)
        at io.reactivex.Flowable.subscribe(Flowable.java:14479)
        at io.reactivex.internal.operators.flowable.FlowableMap.subscribeActual(FlowableMap.java:37)
        at io.reactivex.Flowable.subscribe(Flowable.java:14479)
        at io.reactivex.internal.operators.flowable.FlowableElementAtSingle.subscribeActual(FlowableElementAtSingle.java:41)
        at io.reactivex.Single.subscribe(Single.java:3438)
        at io.reactivex.internal.operators.single.SingleZipArray.subscribeActual(SingleZipArray.java:63)
        at io.reactivex.Single.subscribe(Single.java:3438)
        at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
        at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
        at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
        at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
        at java.lang.Thread.run(Thread.java:764)
     Caused by: java.io.InterruptedIOException
        at okhttp3.internal.http2.Http2Stream.waitForIo(Http2Stream.java:579)
        at okhttp3.internal.http2.Http2Stream.takeResponseHeaders(Http2Stream.java:143)
        at okhttp3.internal.http2.Http2Codec.readResponseHeaders(Http2Codec.java:125)
        at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.java:88)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
        at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.java:45)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
        at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.java:93)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
        at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:93)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
        at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:126)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:147)
        at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:121)
        at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:200)
        at okhttp3.RealCall.execute(RealCall.java:77)
        at org.web3j.protocol.http.HttpService.performIO(HttpService.java:151)
        at org.web3j.protocol.Service.send(Service.java:35)
        at org.web3j.protocol.core.Request.send(Request.java:73)
        at org.web3j.protocol.core.-$$Lambda$KiEniAM70PKnVH3c3FV-XYYYWF0.call(Unknown Source:2)
        at org.web3j.protocol.core.RemoteCall.send(RemoteCall.java:31)
        at org.web3j.protocol.core.-$$Lambda$gE3Z3_l3iQHxXAJugv_wSeyhask.call(Unknown Source:2)
        at io.reactivex.internal.operators.flowable.FlowableFromCallable.subscribeActual(FlowableFromCallable.java:39)

Ethereum Light Client

Store block headers in Room

Fix double spend on eth based networks

Track and increase nonce for outgoing transactions.

Nonce provider can give same nonce when it's already used in other transaction. This leads to double spend or transaction drop-replace https://info.etherscan.com/transaction-dropped-replaced/.

Creation of new OkHttpClients instead of reusing one

Erc20Kit can work with only one token at a time. Each instance of Erc20Kit requires new TransactionManager which in turn requires EtherscanTransactionsProvider which needs EtherscanService. Each new EtherscanService creates new instance of OkHttpClient which is resource-heavy. Is there some specific reason for it?

It would be great if users will be able to provide OkHttpClient through class constructors as it allows proper resource management on app level.

Implement send transaction

• Create raw transaction
• Sign it
• Relay it using SendTxV2 message