hpi-swa-teaching/imapclient

This project provides a library and tool set to access email through IMAP in the Squeak/Smalltalk environment. (SWT22-13)

imapclient's Issues

Please readd the deleted metadata

The develop branch is missing:

• .travis.yml and .smalltalk.ston. How do you even Travis-CI?
• LICENSE. It is morally questionable to remove the License.
• README. The MIT license (The license the original Client is under) requires stating the original authors. Removing the README amounts to license violation.

Just reverting the files should fix these issues.

Set up Travis

ICEndpoint>>rootfolder should return the actual root folder

Currently its just an empty ICFolder with several nil-children.

Client doesn't parse headers correctly

The clients fetchheaders function works, but then fails to parse/render them into the UI.

Response class?

ICEndpoint owns methods to check the responses. These could also be used by other objects. Maybe it is a good idea to encapsulate these in a Response class?

Naming scheme for tests?

move (default-)messageId at ICEndPointCommandTest to class side

How to deal with invalid parameters?

For example a user wants to fetch mail with a messageId which not exists, what should fetchHeader do?

Implement test cases for ICFolder class

Within my latest commit we implemented our new class ICFolder.
We need to find some useful ways to test this new class.

I already wrote a test scenario when adding new folders in the hierarchy.

Add functionality to mark E-Mails as \Flagged and \Seen

The IMAP protocol includes flags for \Answered \Flagged \Deleted \Draft \Seen.
We should be able to incorporate functionality for flagged, draft and seen. Flags for \Answered may be difficult without SMTP. Also we shouldn't care about flags for deletion, since we put deleted emails simply in the "trash-folder" (but this should be done in a different issue).

Test refactoring

TestCase method not used properly

for example:
[self assert: (self endPoint ping)] on: Exception do: [ ^ self ]. self fail
self should: (self endPoint ping) raise: Exception

self assert: (self endPoint logout) = true.
self assert: (self endPoint logout) equals: true
or even better: self assert: (self endPoint logout).

Automatically display all folders and do not display "root"

Test for broken connection

Check whether the framework recognizes a sudden connection loss. If this is not the case, implement a feature to handle this behavior.

Improve the Save Credentials Feature

A User who checks his mails on a regular basis, wont fill in his credentials every time. So I implemented the save credentials check box. Its just creating an config.txt in the Resources Directory, where the credentials are stored in plaintext. This is far away from being good. If i hand my squeak image to a friend, i would also give him my password in plain text.

• We shouldnt save the Logindata file into the resource directory of the image
• We should encrypt it somehow. The IMAP Client should be the only one able to decrypt it again. But how should we implement this? Any Ideas?

Quoted Printable Encoding

Many mails are encoded with quoted printable. https://de.wikipedia.org/wiki/Quoted-Printable-Kodierung
.We should convert it into normal ASCII before trying to parse it. We can recognize it with: Content-Transfer-Encoding: quoted-printable

ICEnpoint should save the hierachyblank for later usage

rename ICEmailObject -> ICEmail

Write User stories for second meeting

Take the notes from the first meeting and turn it into user stories.
Find an scoring system and score the user stories.

ICAuthenricationInfo>>isValid misleading name?

The message checks if the username and passwort differs from the default values.
If the default values are not valid values, the name default value is a little bit misleading?

Furthermore if a server has these default values as user credentials, they can not be used, because they are incorrectly recognised as "inValid".

In my opinion these message is not necessary and can be deleted

ICEndpoint with SSL enabled returns SSL error -2 on closing

Fix error when trying to get 5 or more messages in the "Trash" folder

Please fix up the branches

Only master and develop should be used when I look at the following.

Refactor parse messages for ICEmailObject

Server connection closed after inactivity

Seems like the server is closing the connections after a few minutes of inactivity. We should find a way to reopen the connection. At the Moment i cant open any mails anymore, after waiting for a few minutes.

Tests for state behavior in IMAP-protocol

Login command does not use quotes yet

Make "Get Email" work for the "Sent" folder

Remove folders unnecessary to the IMAP window

Do not display: Tasks, Notes, Outbox, Journal, Check, Info, Items, Contacts

deleting emails may change messageIDs stored in Email object

Currently a dynamic message id is stored in an email object. The message ids are enumerated beginning from 1 on the server. If a email is removed out of our system from the server, the stored message ids may not be up to date.
This could be fixed by a server wide global message id or by fetching the message ids every time before they are used.

Find verifiable metric to test code coverage

Add MockStream-User-Story to Google Docs document

Add functionality to mark E-Mails as read/unread

Sobald der Inhalt einer Email geöffnet wird, wird die Email als gelesen markiert.
Die Schrift von Betreff, Absender und Datum einer ungelesenen Email wird fett markiert.
Eine gelesene Email wird nicht fett markiert.

Constants on class or on instance side

In SWA we learned (from @krono) that constants should be implemented on instance side of classes.
In @Hannes01071995 and my opinion this does not make much sense. Since constants should be constant for every instance of a class this should be on class side.
Please state your opinion.

Feature: Delete emails

Deleting messages in IMAP is a bit tricky, as there is no explicit delete command. Instead, a flag is set on the message marking it as deleted. This, by itself, does nothing to get the message removed. Just when a special command is called all messages in the current folder marked as to be deleted are removed.

. UID SEARCH ALL

• 1 EXISTS
• 1 RECENT
• SEARCH 1814
  . OK Completed
  . UID STORE 1814 +FLAGS (\Deleted)
• 1 FETCH (FLAGS (\Recent \Deleted \Seen) UID 1814)
  . OK Completed
  . EXPUNGE
• 1 EXPUNGE
• 0 EXISTS
• 0 RECENT
  . OK Completed
  . UID SEARCH ALL
• SEARCH
  . OK Completed

The above is executed in a folder containing just a single message (see the result of the UID SEARCH ALL). The flag \Deleted is then added to flag list of the message (UID STORE 1814 +FLAGS (\Deleted)). The STORE command returns the new flag list. The EXPUNGE command then removes the message.

using cascades

In particular ICEndpoint>>initalize

improve parsing for fetchHeaderResponses because the order of the header fields varies

Inconsistent naming of ICEndPoint respectively ICEndpoint

• ICEndPointTest
• ICEndpoint

Test fetching email headers in range if some emails do not exist

At the moment we assume, that all email-IDs in the range are assigned

improve interface for connect methods

At the moment a error is thrown if the connect fails otherwise it returns true.
For me it is a little bit confusing. Either the return value should be checked to indicate failure or the failure is indicated through an exception. As far as I know currently no message (for example UI) checks the return value, so it should be enough to check for exceptions?

Remove ICStringFormatter

The message noopCommand on class site of ICEndpoint still uses ICStringFormatter

ICEndpoint>>loggedIn and ICEndpoint>>isLoggedIn redundant?

If I understand the command in Slack correctly the getter for a boolean variable should be named in the form is{instancevariable}. Is it then necessary to have an other getter?

Modelling no-connection in tests?

Remove comments in source code resp. using message comments

• ICEndpoint>>connectTo: a "stream nextResponse" call is needed to skip the server greetings. Since this call is on a different abstraction level and the purpose is not clear a commend was used.
  Ideas:
  1. a skipServerGreetings message which encapsulate this line
  2. a checkServerGreetings message which encapsulate this line and could (later) check the greeting for success etc.
• ICEndpoint>>fetchNextResponse
  ideas:
  1. using the message comment
• ICEndpoint>>folderFromResponse
  idea:
  1. using the message comment

Implement timeout for fetchNextReponse

Currently, the framework does not time out if fetchNextResponse does not deliver a response.

Don't open the IMAP window, if connection failed

Window opens on error: "ConnectionTimedOut: Data receive timed out"

Tests call other tests

testLogout_EverythingFine calls testConnectToOnAndLoginUsing_EverythingFine

Short to long message lines

There are some too long message lines. These can be found with "SwaLint Code Critics"

requirements.txt für Python-Worker updaten

ICLoginDialog: more appropriated error message for empty fields

After clicking login in the ICLoginDialog a ugly, not helpful Error message appears.
It would be better to catch the case of empty text fields when clicking login button.

Fetching Email Bodys often fails

Maybe we should collect here different types of mails, which cant be parsed atm:

So i wanted to open an amazon mail, which fails in the parseFetchBody Method within the Function asTextFromHtml. So there are 2 issues at the moment. The Amazon Mail contains two Content-Types.
Content-Type: text/plain; charset=utf-8 and Content-Type: text/html; charset=utf-8. I think as long as we are not able to display css with html properly (we should think about using an squeak web browser?). We should always go for the Content-Type: text/plain; charset=utf-8. Often Emails are sent with both Content-Types for devices not capable of displaying HTML.

At the Moment our parseFetchBody method is just

((self lastResponse copyFrom: 2 to: (self lastResponse size - 1)) joinSeparatedBy: Character cr) asTextFromHtml 

Instead of taking everything from 2 to last -1 index, we have to parse the body, looking for content-types and only render the specific content-type.