hubot-archive/hubot-business-cat

Business cat is summoned when business jargon is used

hubot-business-cat's Issues

Opps, sorry! I didnt mean to commit against your repo

So so sorry, i meant to open a Fork it and PR against it, and i hit commit instead.

61c879b

Basically, i wanted to have "net-net" be a trigger.

I tried figuring out how to revert and it seems i cant. 😢

Add the ability to remove phrases as well as add

Hi, Love the plugin ❤️🐈

There are a few phrases that we like "ping me" that don't feel very corporate, maybe we can also have a way to remove or replace the list of phases as well as just adding? I can work on a PR for this.

Word separation

Just had a rather unusual incident where someone, whose name contained the word "guru" (amongst many other letters) was mentioned in a room and business cat was summoned.

Could this plugin search for actual separated words?

jargon could end up undefined

https://github.com/hubot-scripts/hubot-business-cat/blob/master/src/businesscat.coffee#L27

In removeTerm(), if a term is not found, it returns undefined due to the return being nested inside of the if [found]. Thus, if the last term in omittedJargon is not found, jargon will be set to undefined.

Possible fixes:

• I think reducing the indent on the return will fix this.
• Don't return anything and remove the jargon = from the omit line. removeTerm alters the incoming list.

Problem:

coffee> jargon = [1..5]
[ 1, 2, 3, 4, 5 ]
coffee> jargon = removeTerm(term, jargon) for term in [3, 99]
[ [ 1, 2, 4, 5 ], undefined ]
coffee> jargon
undefined

Possible solution 1:

------> removeTerm = (term, arrayToDeleteFrom) ->
.......   index = arrayToDeleteFrom.indexOf term
.......   if index > -1
.......     arrayToDeleteFrom.splice index, 1
.......   return arrayToDeleteFrom
[Function: removeTerm]
coffee> jargon = [1..5]
[ 1, 2, 3, 4, 5 ]
coffee> jargon = removeTerm(term, jargon) for term in [3, 99]
[ [ 1, 2, 4, 5 ], [ 1, 2, 4, 5 ] ]
coffee> jargon
[ 1, 2, 4, 5 ]
coffee>

Possible solution 2:

coffee> jargon = [1..5]
[ 1, 2, 3, 4, 5 ]
coffee> removeTerm(term, jargon) for term in [3, 99]
[ [ 1, 2, 4, 5 ], undefined ]
coffee> jargon
[ 1, 2, 4, 5 ]
coffee>

Triggers on non-listed words

We're using this tool-of-high-productivity in Slack, but we're getting triggers against variations of the word "droid". As you can imagine it also picks up all "Android" references.

I don't see that in the trigger list. Any ideas?