hugohabicht01/petrolstationapp

Webapp that displays real time petrol prices of petrol stations in Germany

petrolstationapp's Issues

Move petrol station logic to the Details component

Right now all the logic for fetching details of petrol station (and the directions renderer) are inside the PetrolStationList componenent. It would be better to move all of this inside the Details component, which is a more logical place to have it and makes it possible to set Details from other components as well

Add pricehistory

Keep pricehistory of all tracked petrol stations in a DB using Google Cloud Platform or cron jobs
See https://cloud.google.com/appengine/docs/standard/python3/scheduling-jobs-with-cron-yaml and https://cloud.google.com/run/ for further research

Test the GMaps API calls

So far there is a test but it is failing, since I'm working with fixed values. This shouldn't be the case. Need to mock the API call

Add proper solution to handle API keys

As of right now, the api keys needed by the backend are specified as environment variables in app.yaml. This isn't optimal as I can't commit the file in that state.
A possible solution would be using gcp secrets

Add option to specify the fuel consumption of your car

So far you can't specify the fuel consumption of your car neither can you can specify how much petrol you need

Integration tests

Enforce consistent naming and style conventions

Right now some variables are named using camelCase, some others are using snake_case. Decide what should be used and enforce a consistent coding style. Probably take a look at the style of popular repos

Frontend: Use vuex for full state management

As of right now only a few bits of data are stored in the vuex store, instead it would be better to use vuex for everything and modularize it as well

Improve naming

Most variable names and especially struct names are horrible as of right now, they need improvement ( you can't just call everything PetrolStations?.*)

use https://pypi.org/project/tankerkoenig/ instead of current solution

Add translations

use vue-i18n to provide german and english text

Add proper unittests for the pricing API

Custom datatype for locations

Add a custom datatype for locations and check if there will be any accuracy loss if floats are used for coords instead of strings

Sort the stations by overall cheapest

Get all the API calls together in a performant way and sort it then

Add Dockerfile

Work around MAX_DIMENSIONS_EXCEEDED

https://developers.google.com/maps/documentation/javascript/distancematrix
If there are more than 25 petrol stations in the radius, google maps will return an error...

Use google maps distance matrix api duration value instead of parsing the text

Right now the duration text is parsed, should be changed to using the value instead

Feature ideas

This should be an issue just to keep track of ideas that come to my mind that could be useful, etc
If I actually start implementing a feature, it might be helpful to create a separate issue for it then

Improve codequality for the dataprocessing after the API calls

The code that processes the data that the APIs returned is very ugly as of right now, it needs cleaning up. Easiest solution would probably be to make it object oriented, to make it at least somewhat clean and readable

Deploy backend to deta

Fix all import issues so that it can be deployed to deta

Change documentation format from Latex to Markdown

Switch from using Latex to Markdown.
Latex might be quite powerful but markdown is just easier to use and can be rendered in the browser on github without having to compile it.

Refine petrol usage model

The petrol consumption model is very basic so far, some improvements would help a lot

Plan frontend