hugsy/binja-retdec

Binary Ninja plugin to decompile binaries using RetDec API

binja-retdec's Issues

Segfault BN stable version 1.1.1142

Didn't investigate it much but using the latest stable BN provokes that the plugin crashes all the time.
Platform: Linux Ubuntu 18.04 x64

$ dmesg
[94146.737828] binaryninja[30428]: segfault at d0 ip 00007f21de097e01 sp 00007ffe7802d620 error 4 in libpython2.7.so.1.0[7f21ddf77000+2e1000]
[94346.471228] binaryninja[30818]: segfault at d0 ip 00007f3644fe6e01 sp 00007ffc6af0be80 error 4 in libpython2.7.so.1.0[7f3644ec6000+2e1000]

Do not hardcode a default API key

Hi Hugsy. I am one of the developers behind RetDec. Thank you for your interest in our decompiler and use of the RetDec's API to create a plugin for Binary Ninja. We much appreciate this.

We would like to kindly ask you to remove the default API key from your source files and to generate a new one that will be used just by you. In the API documentation, we ask the users to keep their API key a secret and not to disclose it to anyone. Each user has to use his or her own API key. Otherwise, we will be forced to block the account that caused the API key to leak.

Python plugin 'binja-retdec' could not be loaded

OS Version

Windows 10

Python

I have both: 3.6 & 2.7

Binary Ninja

Version 1.1.989 Personal (2017-11-07 06:25:32)

Error messages:

Traceback (most recent call last):
  File "C:\Users\xxxx\AppData\Roaming\Binary Ninja\plugins\binja-retdec\__init__.py", line 12, in <module>
  File "C:\Users\xxxx\AppData\Roaming\Binary Ninja\plugins\binja-retdec\retdec.py", line 9, in <module>
    import requests
ImportError: No module named requests
Python plugin 'binja-retdec' could not be loaded

I did run:

pip install requests
pip3 install requests
pip3 install pygments
pip install pygments

output:

C:\Users\xxxx>pip install pygments
Requirement already satisfied: pygments in c:\python27\lib\site-packages

C:\Users\xxxx>pip install requests
Requirement already satisfied: requests in c:\python27\lib\site-packages
Requirement already satisfied: urllib3<1.23,>=1.21.1 in c:\python27\lib\site-packages (from requests)
Requirement already satisfied: idna<2.7,>=2.5 in c:\python27\lib\site-packages (from requests)
Requirement already satisfied: chardet<3.1.0,>=3.0.2 in c:\python27\lib\site-packages (from requests)
Requirement already satisfied: certifi>=2017.4.17 in c:\python27\lib\site-packages (from requests)

license

Given the more restrictive retdec API license, it's probably a good idea to include more details about the restrictions in the description so people using the plugin are aware of the additional restrictions. (non-commercial use only, governed by these terms: https://retdec.com/legal-info/)

MacOS variant stalls/hangs at "Integrating Binary Ninja Symbols...

everything loads fine, but the status hangs with no progress...or logs to indicate any errors.

plugin can't find modules on MacOS

ok...prereqs are installed and teh plugin is in the correct directory.

but when starting Binary Ninja, the plugin fails to load and the log indicates that it's on the import of retdec module as well as the requests module.

see attached.

it works correctly on Linux, but not MacOS...

Issues running on OSX

Cloning and running BN with pyenv set to system (2.7.X) does not populate right click menu with option to decompile.

Any suggestions?

Issue with AttributeError: 'X509' object has no attribute '_x509'

i am getting this error when i try to use this plugin. I tried upgrading python crypto and pyopenssl but that doesnt seem to be fixing the issue. I am running the latest version of binary ninja on ubuntu 16.04

OSX - Hang on 'Decompiling function * with RetDec'

Similar to issue #5 however stuck on the 'Decompiling function name with RetDec'

I've had a look through the code and i'm really not sure what is causing the issue.

Shutdown of the online decompilation service on retdec.com

Hello @hugsy,

I am one of the developers behind RetDec. In December 2017, we have open-sourced our decompiler. Its source code is now available on GitHub under the MIT license. RetDec supports all the three major operating systems (Linux, Windows, macOS), which allows users to build the decompiler on their PC and use it offline.

Due to the fact that anyone can now run RetDec on their machine and our lack of resources to keep the online decompilation service running (it has not been updated since 2017), we have decided to shut the service down. We have already stopped the web-based version of the service (see this announcement) and registrations. Soon, we will also stop the API-based decompilation service, which will render your plugin non-functional.

We just wanted to give you a heads up so you can e.g. insert a note into the README. From what we have found, there seems to be a Binary Ninja plugin that uses the offline version of RetDec. We have not evaluated it so we are not sure whether it works or how good it is, but we believe that it could maybe be used as a replacement.

Thank you for your work on the plugin.