hydrane/angular2-notification-bar

angular2-notification-bar's Issues

It won't work with angular-cli

your usage pretty confuse me.

this.notificationBarService.create({ message: 'USER_SAVED', type: NotificationType.Success});

NotificationType doesn't exist on your project , where can I find it ?

How to close a notification bar if all the hide params are false

Hi,
I have a case when a user not permitted to close a notification,
but I'd like to close this notification a little bit later manually.
May be you could provide this functionality? Generate some ID on notificationBarService.create and give ability to hide a notification by id throught the service

Cannot read property 'text' of undefined

Hello
Thank you for this awesome module.
When i build the project as a production with the angular cli i got this error message :
ERROR in ./~/angular2-notification-bar/src/notification-bar.service.ts Module build failed: TypeError: Cannot read property 'text' of undefined at Object.getTokenPosOfNode (/home/orange/Desktop/projects/maker/maker-front/node_modules/typescript/lib/typescript.js:5692:71) at IdentifierObject.TokenOrIdentifierObject.getStart (/home/orange/Desktop/projects/maker/maker-front/node_modules/typescript/lib/typescript.js:53623:23) at IdentifierObject.TokenOrIdentifierObject.getText (/home/orange/Desktop/projects/maker/maker-front/node_modules/typescript/lib/typescript.js:53644:77) at refactor.findAstNodes.filter (/home/orange/Desktop/projects/maker/maker-front/node_modules/@ngtools/webpack/src/loader.js:138:44) at Array.filter (native) at refactor.findAstNodes.forEach.node (/home/orange/Desktop/projects/maker/maker-front/node_modules/@ngtools/webpack/src/loader.js:137:14) at Array.forEach (native) at _removeDecorators (/home/orange/Desktop/projects/maker/maker-front/node_modules/@ngtools/webpack/src/loader.js:128:10) at Promise.resolve.then (/home/orange/Desktop/projects/maker/maker-front/node_modules/@ngtools/webpack/src/loader.js:304:33) @ ./~/angular2-notification-bar/index.ts 2:0-47 @ ./src/app/auth0/auth.service.ts @ ./src/$$_gendir/app/app.module.ngfactory.ts @ ./src/main.ts @ multi ./src/main.ts
version :1.2.3
angular version :2.3.1
cli version : 1.0.0-beta.32.3

Unit testing with karma

Hello,

I need some help/advice since I am stuck on a problem with unit testing my AppComponent. This is the component containing the notification-bar. I cannot seem to get my unit tests for this component working because of something that has to do with this plugin.

If I import the NotificationBarModule in my tests I get this error : Cannot read property 'unsubscribe' of undefined.

If I import only the NotificationBarComponent i get this error : No provider for NotificationBarService.
And I can't seem to provide the NotificationBarService (I tried a lot of things).

I am not sure if the problem is on my end or not, but if you have some working unit tests could you perhaps help me out? I could provide more information if you need it.

Thanks,
Alexander

Using with Angular 6

Installed the plugin and built it. No issues. But when i use it, it says

\node_modules\a ngular2-notification-bar\index.ts is missing from the TypeScript compilation. Pl ease make sure it is in your tsconfig via the 'files' or 'include' property. The missing file seems to be part of a third party library. TS files in publishe d libraries are often a sign of a badly packaged library. Please open an issue i n the library repository to alert its author and ask them to package the library using the Angular Package Format (https://goo.gl/jB3GVv).

any idea?

Close icon not showing

I am using these versions of angular 2, material and cli:
@angular/core: 2.4.9
@angular/material: 2.0.0-beta.2
@angular/cli: 1.0.0-rc.1

For me the icon inside the close button is not showing, but the button is there. http://prntscr.com/ehgchp
Also is there a way to change the height of the notifications?

Eval Error

I've installed the package, and set in my system config:

'angular2-notification-bar': 'node_modules/angular2-notification-bar/release/bundles/angular2-notification-bar.umd.js',

However, it fails to load with:

"(SystemJS) Invalid left-hand side in assignment ReferenceError: Invalid left-hand side in assignment at eval (<anonymous>) at ZoneDelegate.invoke (http://localhost:3000/node_modules/zone.js/dist/zone.js:330:26) at Zone.run (http://localhost:3000/node_modules/zone.js/dist/zone.js:126:43) at http://localhost:3000/node_modules/zone.js/dist/zone.js:679:57 at ZoneDelegate.invokeTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:363:31) at Zone.runTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:166:47) at drainMicroTaskQueue (http://localhost:3000/node_modules/zone.js/dist/zone.js:529:35) at XMLHttpRequest.ZoneTask.invoke (http://localhost:3000/node_modules/zone.js/dist/zone.js:420:25) Evaluating http://localhost:3000/node_modules/angular2-notification-bar/release/bundles/angular2-notification-bar.umd.js Error loading http://localhost:3000/node_modules/angular2-notification-bar/release/bundles/angular2-notification-bar.umd.js as "angular2-notification-bar" from http://localhost:3000/app/app.module.js"

I'm not sure if this is a bug or if I'm configuring something wrong.