Comments (12)
@outSH, created a task for it: #189
from iroha-javascript.
@outSH I will update you as soon as I get the decision on that matter.
from iroha-javascript.
@6r1d This might help a little bit (but do let me know if it doesn't). The migration from grpc
to grpc/grpc-js
is meant to be fairly straightforward. What I mean by that is that when I was migrating parts of the Cacti codebase the same way, 99% of the time the only thing I needed to do was to replace the package imports in the code and everything would just work fine out of the box afterwards. There was no need to refactor the code and risk introducing new bugs, etc.
from iroha-javascript.
@6r1d I just ended up sending in a quick PR. It's a pretty simple change. I verified that it works with our Cacti Iroha connector tests.
See my PR: #182
from iroha-javascript.
I recommend migrating to the new, purely JS implementation instead because the legacy grpc
package has been deprecated for a long time now:
from iroha-javascript.
@6r1d @0x009922 Any updates regarding this? It's blocking our CI at the moment. Let us know if this package is still supported and can have grpc fixed / updated in the nearest future. If it's deprecated (or is about to be), then we could remove support for Iroha V1 from cacti.
from iroha-javascript.
Hi @outSH
I cannot help you with the functionality related to Iroha 1, unfortunately.
@6r1d, what about support of Iroha 1 in cacti?
from iroha-javascript.
@6r1d Thanks for looking into that, any news so far?
from iroha-javascript.
@outSH, I'm still looking for someone who could help.
from iroha-javascript.
TBH, I am not sure why this error occurs in runtime, because grpc
library is not imported from what I can observe in source code.
However, grpc
is imported in a .d.ts
file, which means it must be a production dependency, not a dev one.
With this in mind, I've approved #174.
upd: I am blind, just saw #182, nevermind.
from iroha-javascript.
@6r1d @0x009922 Hi, do you plan to release a version containing this fix?
from iroha-javascript.
@6r1d @0x009922 any news regarding releasing new version with that fix? :)
from iroha-javascript.
Related Issues (20)
- Perform Permissions with Typescript SDK HOT 2
- Move WASM singleton from `@iroha2/client` to `@iroha2/crypto-core`
- Expose "append signature" utility
- Remove `accountId` from the `Signer`
- Include hex utilities into SDK
- Add versioning matrix
- Generate data model as Markdown and track in in Git
- npm init
- Add a check that block height is >= 1 HOT 1
- Unexpected type (Quantity / Fixed) HOT 1
- getting Unsupported Operation for transfers HOT 4
- Store asset information is incomplete when querying with JS Api (works with iroha_client_cli) HOT 6
- error executing FindTransactionsByAccountId query HOT 1
- Use original `iroha_crypto` crate HOT 1
- Release new version
- Restructure crypto code HOT 2
- Github branching model HOT 1
- Error while registering a new peer HOT 3
- Issue with crypto library with Next.Js HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iroha-javascript.