Giter Site home page Giter Site logo

Comments (3)

matisalimbene avatar matisalimbene commented on June 24, 2024 1

@0x009922 Thanks, that makes sense. I tested your solution and it did work with a minor fix.

I needed to add "hex" to fromMultiHash like so:

const public_key = freeScope(() => crypto.PublicKey.fromMultihash('hex', public_key_hex).toDataModel())

Thanks!!

from iroha-javascript.

0x009922 avatar 0x009922 commented on June 24, 2024

Hello Matias,

I guess the issue is with this code:

const public_key = PublicKey({
    digest_function: Algorithm('Ed25519'),
    payload: Uint8Array.from(Buffer.from(payload, 'hex')),
});

The issue is that your payload is not a payload, but a complete public key in multihash format. Therefore, when you create datamodel.PublicKey, you add again multihash prefix, resulting in duplication.

To handle this in the most proper way, let the crypto library handle the multihash:

import { crypto } from '@iroha2/crypto-target-node'
import { freeScope } from '@iroha2/crypto-core'

const public_key_hex = 'ed0120C69B431324D855E945B64F8DD757BDB5ED10C915C9C33ED6C1B36E06B97046F0'

const public_key = freeScope(() => crypto.PublicKey.fromMultihash(public_key_hex).toDataModel())

from iroha-javascript.

0x009922 avatar 0x009922 commented on June 24, 2024

Ah, yes, indeed. Glad it's fixed!

from iroha-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.