ianoxley/encdec

A small JavaScript library for base-xx encoding / decoding

encdec

Please see https://github.com/ianoxley/node-encdec.

(This repository is no longer actively maintained).

encdec's Issues

Incorrect caching of digits within alphabet

Code that exhibits the bug:

var base24 = encdec('BCDFGHJKLMNPQRSTVWXZ1345');

base24.encode( 1 )
// Correctly encodes 1 to 'C'
// caches as {1 : 'C'}

base24.decode( '1' );
// Should decode to 20, but it returns 'C' due to cache

/* If done in reverse, {1 : 20} would have been cached and
   base24.encode( 1 ) would have incorrectly returned 20
*/

If 0-9 do not map to themselves, they will be incorrectly cached.

Can't encode zeroes

Basically, I'm trying to work with zeroes, but it returns an empty string instead of the correct letter.

var base24 = encdec('BCDFGHJKLMNPQRSTVWXZ1345');
console.log( base24.encode(0) ); // Should return 'B', but returns ''

I had a look, and I think this occurs because encdec checks num as a boolean here, treating 0 as false:

if (num) {
  encode = alphabet[num] + encode;
}

Possible fix:

if (num>=0) {
  encode = alphabet[num] + encode;
}

It's possible that this check isn't even necessary.

License?

Hey Ian,

I noticed there wasn't a license associated with this project. Would you be willing to release it under a BSD style license so I can use it in one of my projects?

Jud