ibicha/imageeffectgraph

Image effects for post processing stack created with shader graph for Unity

imageeffectgraph's Issues

Add plane PreviewType tag

"PreviewType"="Plane" in the subshader generator

[TIP] Legacy effects (without Postprocessing Stack)

It is currently possible to use the created effects directly on the camera (aka using OnRenderImage), without the need for the postprocessing stack.

For this, two things needs to be done:

1. Step 1: Property blocks needs to be generated. simply change this line here from:

generatePropertyBlock = false

To:

generatePropertyBlock = true

For some reason, the postprocessing stack only works with false, and OnRenderImage only works with true.

2. Step 2: Comment out this line:

#ifndef UNITY_POST_PROCESSING_STACK_V2
 //#define UNITY_POST_PROCESSING_STACK_V2 // comment this line to use without postprocessing stack
#endif // UNITY_POST_PROCESSING_STACK_V2

This keyword is supposed to be passed from script, so the shader compiler knows what to compile (postprocessing stack vs legacy effect) but due to keyword count limit to 256, this might fail.

Finally, open the shaders in shader graph and save again (this should happen automatically if you edit the legacyEffectPass.template file, so do this in case it doesn't). The effects should be working WITHOUT the postprocessing stack using this script.

2019.1 support ?

Right now, it appears to be tool is not compatible with Unity 2019.1+ due to changes that they've made. I'm getting errors like this:

Better previews in shader graph

Previews in the shader graph nodes are completely broken hacky, dirty and unreliable.

Currently they rely on a global texture _PreviewTexture set by the custom effect.

The shader graph gui needs to be capable of capturing the game view before effects reliably, so the graph is capable of showing the transformation of the original texture into the destination master.

Need ideas on the best way to implement this (the current way can be improved to be honest)

Packaging

Make into a package available to the package manager

Node documentation

New nodes introduced in this repo need to have documentations added to each class.

Support install from package manager

In 2018.3.0b7 added support for git package dependencies from package manager :
https://forum.unity.com/threads/git-support-on-package-manager.573673/

Here is the guide to make a custom package:
https://gist.github.com/LotteMakesStuff/6e02e0ea303030517a071a1c81eb016e

Do you think this is a good idea to support it ? If so, i could try to make a PR.

Can't use multiple effects at once

Post processing profile prevents from adding the same effect more than once.
Even when using hacks, and successfully adding more than one effect of the same type, the renderer will only render one of them not both. This is needs to be updated in the post processing stack side.

As a work around, for each additional effect you want to use:

1. Create a class that inherits from RenderWithMaterial like so:

using System;
using ImageEffectGraph.PostProcessing;
using UnityEngine.Rendering.PostProcessing;

namespace ImageEffectGraph.Demo
{
    [Serializable]
    [PostProcess(typeof(RenderWithMaterialRenderer), PostProcessEvent.AfterStack, "Custom/My Other Effect")]
    public class MyOtherEffect : RenderWithMaterial
    {
    }
}

2. Create an editor (inspector) for that class that inherits from RenderWithMaterialEditor like so:

using ImageEffectGraph.Demo;
using ImageEffectGraph.Editor.PostProcessing;
using UnityEditor.Rendering.PostProcessing;

namespace ImageEffectGraph.Editor.Demo
{
    [PostProcessEditor(typeof(MyOtherEffect))]
    public class MyOtherEffectEditor : RenderWithMaterialEditor
    {
    }
}

And now you should be able to add the new effect from the editor:

These are included in the repository for the sake of the example, until this is permanently fixed.

Multiply node breaks the graph

Unity Version: 2018.3.0b9
When try to connect a multiply node and multiply Maintexture output with color node then assign it image effect node, it doesnt work and become one of "not compiled shaders". Middle of screen became pink with a triangle. (There is a cube over there.) Error like this:

Screenshots as follows:

SubShader generation cleanup

The subshaders generators (all 3 of them) are pretty much a hacky copy paste from the unlit shader of LWRP.

Probably need a rewrite, to reflect shader features of different pipelines.