icatproject/icat.client

Java client for ICAT

icat.client's Issues

Release 4.5

Internal exceptions should not be exposed

The following attempt to add a new datafile to an existing dataset:

    datafile = [{"name" : "df3", "location" : "loc3", "dataset" : {"id" : newdsid}}]
    entity = {"Datafile" : datafile}
    self.session.write(entity)

resulted in the stack trace:

Traceback (most recent call last):
File "test.py", line 173, in test12AddFile
self.session.write(entity)
File "/usr/local/lib/python2.7/dist-packages/icat.py", line 332, in write
return self.icat._write(self.sessionId, entities)
File "/usr/local/lib/python2.7/dist-packages/icat.py", line 143, in _write
self._check(r)
File "/usr/local/lib/python2.7/dist-packages/icat.py", line 64, in _check
raise IcatException(json["code"], json["message"])
IcatException: INTERNAL: class javax.ejb.EJBException Stateless SessionBean method returned without completing transaction

Provide getMaxEntities call

Dependencies need updating

There are a few dependabot PRs relating to this but other dependencies need updating as well

Documentation for escaping quotes is wrong

ordering by calculated fields does not work

According to:

https://en.wikibooks.org/wiki/Java_Persistence/JPQL_BNF#New_in_JPA_2.0

the following should work:

select CONCAT(investigation.name, '-', investigation.visitId) as orderBy1, investigation from Investigation investigation where investigation.name = 'APPLIEDAHEAD' ORDER BY orderBy1 asc

but it doesn't, instead I get the following response:

{"code":"BAD_PARAMETER","message":"Expected token from types [NAME, DISTINCT, COUNT, MAX, MIN, AVG, SUM] at token CONCAT in SELECT < CONCAT > ( investigation.name "}

This relates to #255

Avoid generation of two packages

It turns out that have a numbered package did not help topcat as maven does not allow two versions of the same component to be included

Release 4.6

Search improvements support

As the search functionality is altered, the client functions will need to reflect this (for the integration tests if nothing else).

drop python client

The python client uses python 2 so will have to be ported to python 3. However, we already have a better, more complete and well-maintained python client api in @RKrahl 's python-icat so it doesn't seem worth the effort.

Update to Apache License

add getSession call when you know the sessionId already

Migrate CI from Travis to GitHub Actions

Description:
The CI needs to be migrated from Travis to GitHub Actions.

Acceptance criteria:

• CI runs

Build fails using Java 11

This is most likely due to the removal of the Java EE modules and thus the SOAP stuff fails.