Better defaults!

[icd2k3]

Better defaults!

[icd2k3]

Hey @nachoaIvarez, thanks for the suggestion! At initial glance I think it sounds like a good improvement idea!

One concern:
Users might not want to render a breadcrumb from some route segments. In this case we'd need some kind of opt-out option if each segment automatically returns a default string.

I should have some time within the next couple weeks to try this idea on my end. In the meantime I'd be happy to take a look at a PR as well!

[icd2k3]

FYI this is now included as part of 2.0.0 along with some other core changes listed here

[nachoaIvarez]

Example:

teams/:teamId/roster-and-staff > Teams / 984752985 / Roster and staff

That should be by default.

And, if instead of showing the ID you want to show the team name, you can still use the routes param in the HOC:

export default withBreadcrumbs({
  'teams/:teamId': ({ match }) => <span>{teams[match.params.userId].name}</span>
})(Breadcrumbs)

teams/:teamId/roster-and-staff > Teams / Actual Team Name / Roster and staff

You have the same result with way less configuration than the currently needed.

[icd2k3]

@nachoaIvarez I have a rough working branch for this so don't worry about a PR - I'll get this cleaned up and released in the near future

[nachoaIvarez]

Thank you for considering my suggestion! I wasn’t able to find time so great you did!

…

On Fri, Feb 23, 2018 at 02:55 Justin Schrader ***@***.***> wrote: @nachoaIvarez <https://github.com/nachoaivarez> I have a rough working branch for this so don't worry about a PR - I'll get this cleaned up and released in the near future — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AG6vNuhNeoz2Mm3LRuFXDhg7NN0UPkCyks5tXlLKgaJpZM4SP4sM> .

[icd2k3]

Nps, thanks for making the suggestion! As a heads up, it may be a week or so before I can get it all merged up and released as I'm a bit busy with work at the moment. Thinking this change will also bump the package to 2.0 so I want to make sure I have the test cases covered + good documentation. I'll post back here once it drops!

[nachoaIvarez]

This is great @icd2k3. Thank you so much.