breadcrumb prop is being ignored.

[icd2k3]

breadcrumb prop is being ignored.

[Pixelatex]

The issue has resolved itself on my repository. Can't reproduce the error anymore, it might be related to something else.

[pimmey]

@icd2k3 I see why it didn't work now - it wasn't clear to me that routesConfig has to be passed to withBreadcrumbs() 🙂thought it should happen automatically or something. Anyway, this should do it, works fine.

[icd2k3]

Ohh, I could do a better job of calling that out in the readme... added a small change here.

Thanks @pimmey!

[icd2k3]

Hey @Pixelatex,

That should work. Could you post your entire route/breadcrumb config array when you have a moment?

Thanks

[Pixelatex]

Got it work by moving the breadcrumb under the path like this:

{
    path: '/careers/:id',
    breadcrumb: 'test',
    exact: true,
    component: CareerDetail
  },

No idea why this is an issue though, really weird bug

[icd2k3]

Strange! Did the order of the route config objects change by chance? The HOC will return the first match, so order can affect how the breadcrumbs are generated: https://github.com/icd2k3/react-router-breadcrumbs-hoc#order-matters

[Pixelatex]

the order of the route objects wasn't an issue, I tried this on a few other routes and it also had the same issue somehow

[icd2k3]

Thanks for the follow-up @Pixelatex!

I adjusted some unit tests to see if I could repro the issue, but so far no dice! When you have a moment, would you be able to post your entire route array? It may help in tracking down the problem.

[pimmey]

Same here, have you guys figured this one out by any chance? :-)

Tried moving the breadcrumb and what not, but nothing changes.

const ROUTES = [
  {
    path: '/yearbook',
    component: Yearbook,
    exact: true,
    breadcrumb: 'Overview orders'
  },
  {
    path: '/yearbook/:id',
    component: Order,
    breadcrumb: 'Overview orders 2'
  }
]

[icd2k3]

Hey @pimmey, thanks for reporting and apologies for the issue. I'm re-opening this thread and I'll try to come up with a repro case tonight!

[icd2k3]

@pimmey I set up a quick code sandbox with your route config and it seems to be working alright... maybe something else is causing the issue? 🤔 are you using any of the option params like disabling defaults, etc?

https://codesandbox.io/s/pknr4kyll0