Giter Site home page Giter Site logo

Comments (5)

icd2k3 avatar icd2k3 commented on May 31, 2024

Hey @frederikgdl, thanks for bringing this to my attention!

FWIW there is a UMD dist output too https://github.com/icd2k3/react-router-breadcrumbs-hoc/blob/master/rollup.config.js#L28 but since you weren't seeing this issue before it does make me think something odd is going on with humanize-string 🤔

I also noticed humanize-string is adding a lot to the bundle size which is obviously not ideal...

I should have some time to look into this issue soon (hopefully by this weekend, at least).

As a short-term fix, I'll probably just downgrade humanize-string to the older version as a 3.0.1 release

from react-router-breadcrumbs-hoc.

icd2k3 avatar icd2k3 commented on May 31, 2024

Good news @frederikgdl I found a method that seems to cover all the same cases humanize-string does, so it looks like I can completely remove it as a dependency: #64

This should fix your error when it is released, and has the added benefit of dropping the build size from ~32kb (gzip) -> ~3kb (gzip)

from react-router-breadcrumbs-hoc.

frederikgdl avatar frederikgdl commented on May 31, 2024

Wow, great news! Thank you so much for your quick response and help!

from react-router-breadcrumbs-hoc.

icd2k3 avatar icd2k3 commented on May 31, 2024

No problem @frederikgdl. 3.1.0 is released and should not have humanize-string bundled with it

from react-router-breadcrumbs-hoc.

frederikgdl avatar frederikgdl commented on May 31, 2024

I upgraded and it now builds without error and works as expected. Thanks again!

from react-router-breadcrumbs-hoc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.