color_picker color change

[iced-rs]

color_picker color change

[latidoremi]

The color picker stores the color alongside with some caches in the overlay state and those don't react to color changes from the outside

Here's a dirty fix which is recreating the overlay state when show_picker is false, the problem is that show_picker will be false for most of the time, and Widget::overlay() is called on every update and draw, multiple times even, meaning that it's a waste of computation to update the overlay state this often

A better solution would be to update the overlay state exactly when show_picker changes, like maybe on click or on hover, but this is a limitation of the color picker that it hands the show_picker flag over to the lib users, it has no idea when show_picker will change and the lib users have no way to update the overlay state by themselves

   fn overlay<'b>(
        &'b mut self,
        state: &'b mut Tree,
        layout: Layout<'_>,
        renderer: &Renderer<B, Theme>,
    ) -> Option<overlay::Element<'b, Message, Renderer<B, Theme>>> {
        let picker_state: &mut State = state.state.downcast_mut();

        if !self.show_picker {
            // new lines begin
            let overlay_state = super::overlay::color_picker::State::new(self.color);
            picker_state.overlay_state = overlay_state;
            // new lines end

            return self
                .underlay
                .as_widget_mut()
                .overlay(&mut state.children[0], layout, renderer);
        }
        ...

[genusistimelord]

yeah I do think there is a way to fix this but it probably requires an additional function to update internals to let the system know to redraw it. currently been pondering this.

[jeffreyrosenbluth]

The dirty fix works. Doesn't seem to impact performance too badly. Let me know if I can help with a more permanent fix.