Comments (6)
this sounds like a decent change!
from iced_aw.
@genusistimelord please review PR #169. I think it is a better solution to support multiple overlays: it removes the show_modal
boolean altogether and changes overlay
into an Option
. This way it allows maximum flexibility in choosing whether to display an overlay or not (by passing None
). The PR is still partial (I updated only the functional code, not the comments / documentation), but would like to get your feedback on this possible approach before completing it.
Actually I think there is even a simpler solution: by removing the Option
from overlay
in PR #169, the user could simply show directly underlay
(without calling modal
) when the overlay should not be shown. This would actually be my preference, but I ask your opinion before implementing it. With this implementation, modal
would always have the overlay visible when called.
If you do not like the two above implementations, then a new multimodal
widget should be added accepting a Vec
of overlays and an usize
. If the usize
corresponds to an element of the Vec
of overlays, that overlay should be shown, otherwise no overlay should be shown. IMHO this is not needed though, as the above two implementations (in particular the second one) are simpler and allow maximum flexibility.
from iced_aw.
yeah just fix the clippy issue as it should be good to merge.
from iced_aw.
Oh and add an example showing multiple modals in usage would be nice too.
from iced_aw.
Hi @genusistimelord I saw that you already merged PR #169 and fixed the clippy issue yourself. Sorry I did not answer before but yes I am adding a multiple modals example, just hold on and I am going to PR it. Before that I am also going to fix the modal's comments and documentation.
from iced_aw.
ok thats fine. PR whenever your ready. I will close this since the last one fixed the problem.
from iced_aw.
Related Issues (20)
- Mandatory copy trait makes it impossible to use custom message with additional parameters HOT 1
- feature request for menu - mac support HOT 1
- Can't use a PickList on a modal HOT 4
- index out of bounds in Tabs HOT 6
- Grid breaks Scrollable HOT 3
- fail to compile on the newest commit HOT 1
- A way to disable on scroll behavior in number_input HOT 1
- Card close_size extends down right when made larger HOT 2
- Grid is not scrolled together with scrollable content HOT 1
- [BUG] `tabs` panic if placed at application root HOT 3
- Numberinput requires mouse hover for keyboard input HOT 4
- number_input, unable to type non-integer numbers. HOT 4
- Number input doesn't prevent overflow and underflow of the contained value
- Is there anyway to move add margins around a modal's overlay? HOT 3
- Dependabot update to 0.9.1 fails HOT 5
- font_loading example display error
- color_picker、date_picker cannot show button icon HOT 3
- Performance of rust-analyzer HOT 1
- Floating element is drawn higher than main menu HOT 2
- card head_text_color doesn't seem to change color HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iced_aw.