Menu crash

[iced-rs]

Menu crash

[genusistimelord]

could you please give the code you used or build a minimal example of this occurring?

[KentaTheBugMaker]

clone https://github.com/t18b219k/voice_vox_gui.git
first we need to install VoiceVox japanese TTS software to run this problematic code.

and cargo run.

[KentaTheBugMaker]

I removed icon but still crash.

[latidoremi]

clone https://github.com/t18b219k/voice_vox_gui.git first we need to install VoiceVox japanese TTS software to run this problematic code.

and cargo run.

Sorry I don't read Japanese but I played with the ui for a bit, none of the crashes came from iced_aw, where exactly should I be looking at?

[KentaTheBugMaker]

modified to check mt.index is valid for menu crash reduced but still crash in on_event.

[KentaTheBugMaker]

sub menu rendering crash + main menu scroll crash.

[latidoremi]

Ok I see where the problem is, the widget tree did not update when the menu tree changed on condition, a simple fix would be to recreate the widget tree in diff since the non linear children structure is a bit tricky to diff, dunno how much it'll affect the performance tho, I'll see if there's a better way

[KentaTheBugMaker]

ok i'm happy to improve menu widget quality.

[latidoremi]

@t18b219k Checkout the code in the linked PR and see if it actually fixed the problem

[KentaTheBugMaker]

Works fine.
oddly crash gone!

[genusistimelord]

I shall push that new change.