icgc-tcga-pancancer/gt-download-upload-wrapper

This tool is used to monitor and make gt-download more robust. To be use primarily withing SeqWare workflows

gt-download-upload-wrapper's Issues

Ideas for Improvements to Downloader

Here are some ideas:

• the first while loop checking "-e $file" will almost immediately be true and exit since the first thing gtdownload does is to create a placeholder file for the bittorrent download
• the main loop will then join on the thread, waiting for an exit
• the actual thread will continue until there's a timeout
• if there's a timeout then the thread will exit
• because the control loop has exited and the program is waiting on the join it will just exit, it doesn't look like there is anything to catch an error state in this case
• you need one final check to ensure that the download did work properly otherwise you may report success when it's actually a failure.