icgog/flowlessly

Min-cost flow solver

flowlessly's Issues

Build fails with clang++

To integrate with the Firmament build flow, we'll need to build Flowlessly using clang++.

Currently, this fails:

malte@eucleia:~/Projects/firmament/ext/flowlessly-git(git)$ make
  CXX     arc.o
  CXX     cost_scaling.o
  CXX     cycle_cancelling.o
  CXX     graph.o
graph.cc:549:3: warning: control reaches end of non-void function
      [-Wreturn-type]
  }
  ^
graph.cc:838:3: warning: control may reach end of non-void function
      [-Wreturn-type]
  }
  ^
2 warnings generated.
  CXX     statistics.o
  CXX     successive_shortest.o
  CXX     utils.o
utils.cc:143:26: error: variable length array of non-POD element type
      'binomial_heap<pair<int64_t, uint32_t>, compare<greater<pair<int64_t,
      uint32_t> > > >::handle_type' (aka 'node_handle<node_pointer, super_t,
      reference>')
                  handles[num_nodes];
                         ^
1 error generated.
make: *** [utils.o] Error 1

This does not appear to be a trivial fix: the handles array is an array of boost::binomial_heap handle types. Maybe what we should do here is define a vector?

Will look at a patch later, but ideas welcome.

Question: Relaxation and Cost scaling are not supported?

Per the paper: Firmament: Fast, Centralized Cluster Scheduling at Scale, Relaxation and Cost scaling algorithms performs better than Cycle canceling and Successive shortest path algorithms. I just can't find Relaxation and Cost scaling in the solver. So, I am wondering why they are not supported in this project?

@ICGog @ms705