icgood/pysasl

Pure Python SASL client and server library.

pysasl's Issues

ModuleNotFoundError: No module named 'typing_extensions'

With pysasl==0.6.1:

>>> import pysasl
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "…/lib/python3.7/site-packages/pysasl/__init__.py", line 6, in <module>
    from .hashing import HashInterface, Cleartext
  File "…/lib/python3.7/site-packages/pysasl/hashing.py", line 11, in <module>
    from typing_extensions import Protocol
ModuleNotFoundError: No module named 'typing_extensions'

Looks like e5b24eb introduced a typo (install_requiers) in setup.py.

Either switch SASLAuth() method list to unicode or reject unicode args

• SASLAuth([b'PLAIN']) will work and populate the server_mechanism attribute.
• SASLAuth(['PLAIN']) will fail silently and do not populate the server_mechanism attribute.

I understand historical (py2) reason but I don't see any reason of using a bytes rather than unicode parameter here. I suggest:

• switching to unicode and still accepting bytes (decoding it to unicode on the fly)
• optionally issuing a DepredactionWarning

If you do not want to change that arg type, then I would expect a type assertion to avoid failing silently with something that may seem valid.

PS: yay, issue #1 ! 🎆