ichun/ding

Dings the client when it loads or when it loads the world. Literally one class file.

ding's Issues

Unable to use with Mod

Hello,

I recently downloaded Ding and found it to be fantastic. While looking in the config file, I noticed that I can use it with mod sounds, too. However, upon trying to use it with audiodeath, I get the error that it can't find the specified sound file "audiodeath:audiodeath.death".

I've confirmed that the audiodeath mod is working fine and is able to find its sound file correctly, and I've confirmed that Ding works fine in its default configuration. So I suspect it's to do with my configuration of Ding. Below are the parts of the file that I've modified.

ding {
# Minecraft name of sound file to play when Minecraft is loaded
# EG: "ui.button.click" or "entity.experience_orb.pickup"
#
# This can also be a mod sound if the mod is installed.
# EG: modname:modsound.boing [default: entity.experience_orb.pickup]
S:name=audiodeath:audiodeath.death
# Minecraft name of sound file to play when world is loaded
# EG: "ui.button.click" or "entity.experience_orb.pickup"
#
# This can also be a mod sound if the mod is installed.
# EG: modname:modsound.boing [default: entity.experience_orb.pickup]
S:nameWorld=audiodeath:audiodeath.death
--LINES REMOVED
# Play sound on...
# 0 = Nothing (why install the mod though?)
# 1 = MC load
# 2 = World load
# 3 = MC and World load [range: 0 ~ 3, default: 1]
I:playOn=3

Clientside only mod (1.16.5-1.3.0)

Hi, can you update your mod to mark it as client only please.
It will cause an error when we forget to install it on server and it's not easy for us, server admin, when we have lot of mod to manage.

You can find informations on:
https://mcforge.readthedocs.io/en/latest/concepts/sides/#writing-one-sided-mods

Thanks

Mark mod as clientside only

Please mark the mod as client only via
https://mcforge.readthedocs.io/en/latest/concepts/sides/#writing-one-sided-mods

right now it will cause a red X in the server list if the mod is missing on the server, thanks!

Update to 1.19.4; will it happen?

Sorry to be that guy, but I would really like to know if there are plans to support this into the future. Thanks.

[1.19] Crashes with newest forge

Ding-1.19-1.3.0
forge-41.0-96
Log: https://paste.ee/p/yVwnU

Suggestion - Add check for when running on server/client

Current behavior causes server crash. Did not know it's a client only mod.

asking

Hello, I'm asking you to make a version for 1.20.2 fabric or quilt on Modrinth, thank you very much!

SUGESTION ding after F3+T

It would be pretty awesome to have the ding after the resourcepack reload finishes since if you Alt-tab too soon the game has a high probability of freezing on large modpacks.

[Forge 1.18.2] Crash upon Loading

When loading up Minecraft with the latest version of Ding installed (1.4.0), the game crashes with this error:

Description: Rendering overlay

java.lang.NullPointerException: Cannot read field "playOnLoad" because "me.ichun.mods.ding.common.Ding.config" is null
	at me.ichun.mods.ding.common.core.EventHandlerClient.postInit(EventHandlerClient.java:35) ~[Ding-1.18.2-Forge-1.4.0.jar%23136!/:1.4.0] {re:mixin,re:classloading}
	at net.minecraft.client.Minecraft.handler$boi000$setOverlay(Minecraft.java:9848) ~[client-1.18.2-20220404.173914-srg.jar%23350!/:?]

I've deleted the config file to allow it to regenerate, and the issue still persists. Full crash log upon request.

Ding is unable to access sounds from other mods when those mods register them using RegistryEvent

I've been trying to get Ding to play a sound from a mod I'm making. However, I keep getting the error Could not find sound: mymod:mysound.

I've done some digging around, and I figured out the problem.

Here's how Ding currently gets and plays the sounds:

SoundEvent useRegistered = (SoundEvent) ForgeRegistries.SOUND_EVENTS.getValue(new ResourceLocation("mymod:mysound"));
Minecraft.getInstance().getSoundHandler().play(SimpleSound.master(useRegistered, 1));

It's trying to get the registered object. However, this doesn't work for mod sounds—it always throws this error message. (I know you haven't updated GitHub with the latest versions of Ding, but it's still pretty much the same)

I tried having Ding re-create the sound reference whenever it needs to play it, and it seems to do the trick. Here's how it works:

SoundEvent recreate = new SoundEvent(new ResourceLocation("mymod:mysound"));
Minecraft.getInstance().getSoundHandler().play(SimpleSound.master(recreate, 1));

Obviously you'd have to change that up to work with the Ding config file, but from my testing this fixes the problem I outlined above.

Here's a gist of Ding.java for the 1.15.2 with my changes.

Edit after some more testing

Alright, I've done some more digging around. It looks like Ding only has this problem when the sounds are registered using Events, as described here. When using DeferredRegister (seen here), it works fine. I guess the problem was sorta on my end, after all.

For anyone else who has trouble with this, here's an example of how you register using DeferredRegister (at least in 1.15).

I think it would be good for you to add something about this to the mod page on CurseForge so others don't have to figure it out like I did! I love the mod.

[1.12.2] Ding too early with LiteLoader installed

As the title says. I found that the mod dings right after all of the texture errors check appear in the log, and right before Forge spams about models. That causes the ding to play when Minecraft is still loading, sometimes even a couple minutes before it's done.
Log: https://pastebin.com/Y1c1je8s

IRC

: So I see Ding works with mod sounds, and vanilla sounds, but is there any way to add a custom sound? I tried making a resource pack with just the one sound I want to play, and I got it to play with /playsound but Ding still doesn't see it. Is there any way to get this to work outside of wrapping the sound in a standalone mod?

[1.15] Suggestion - Play the "ding" sound as music

Would be great to be able to "tag" the sound as music for example.

I know I dont use it as intended, but in my case I use it to start a specific music on server entry.
I got some complains that the music that started can't be lowered using the usual "music volume" options.

Version: MC 1.15

Thanks iChun ;) - even if you reply you can't or don't want to :P

Ding sound play before game launched

Hello!
All is in the title. Here is my log :
latest.log
Thank you by advance

Not working with resource loader?

Hello! I am trying to make a custom work with resource loader on 1.12. My structure is like this: resources/minecraft/sounds/testing.ogg
The sounds.json looks like this:

{
"testing":{
"category":"master",
"sounds":[
"testing"
]
}
}

When I type in Minecraft: "/playsound minecraft:testing voice jackowski" it plays the sound. But Ding doesn't play it. Also tried to add this sound to a resource pack, same issue.

Resource pack sound not working

Hey there,
Thanks for such a great mod.

seems it doesn't accept sounds that aren't minecraft, even when added through resourcepack.
MC: 1.15.2
forge-31.2.36
error:

me.ichun.mods.ding.common.Ding
Render thread
Could not find sound: minecraft:nameofthesound

Anyone got it to work? How?

How to load a custom sound

So im using Kubejs to load a custom sound but I cant seem to make the mod load and play it ive tried a number of things and no matter what I do it refuses to play. The folder structure where it is at is kubejs/assets/kubejs/sounds/load.ogg

Apparently github does not support uploading of ogg files so if you need the file let me know and ill gdrive it.

Just doesn't work with AdditionalResources or ResourceLoader.

In the config it claims to work with sounds added by AdditionalResources and ResourceLoader, but it just doesn't.

I can play the sound in-game with /playsound but Ding just can't find it.

It will log [ding]: Could not find sound: minecraft:barry.wow every single time without fail.