iden3/circom_runtime

circom runtime

circom_runtime's Issues

`calculateWitness()` does not emit an error if there are missing inputs

The following code runs without an error:

const wc = await WitnessCalculatorBuilder(wasm, options)
const witness = await wc.calculateWitness( { }, true)

The circuit in question, however, has three public input signals. calculateWitness should emit an error if any of the signals is not provided.

See https://github.com/weijiekoh/circom_runtime_bug for a demonstration of this error.

Need to check minor version >= 1 as alternative to patch version >=7

Since 2.1.0 has patch at 0

data segment limit exceeds with big circuits

when I write
const wc = await WitnessCalculatorBuilder(wasm, {sanityCheck: true});

this occurs
CompileError: WebAssembly.compile(): data segments count of 191772 exceeds internal limit of 100000 @+609622

this comes from
const wasmModule = await WebAssembly.compile(code);
@ https://github.com/iden3/circom_runtime/blob/master/js/witness_calculator.js

command $snarkjs wtns calculate circuit.wasm input.json witness.wtns
makes same error as well.

[email protected]
[email protected]

WitnessCalculatorCircom2 is still using local fromArray32

In calculateWitness function of WitnessCalculatorCircom2, dropped fromArray32 function is still used, and that makes calls to the function fail.
I assume that it should be replaced by ffjavascript.Scalar.fromArray.

I created PR #18 for this.

Replace fnv-plus

It was suggested in the telegram group that the fnv-plus library be replaced, either with a hand-written implementation or a smaller package, because it is a huge portion of the snarkjs browser bundle and only exists for 1 utility here.