idinium96/node-tf2-schema-2

Hi there 👋

• 🔭 I’m the owner of the TF2Autobot organization
  • autobot.tf
  • schema.autobot.tf
• 🌱 I’m currently still learning TypeScript and JavaScript
• 📫 How to reach me: TF2Autobot Discord Server (https://discord.gg/4k5tmMkXjB)

node-tf2-schema-2's Issues

As of v2 Schemas that use older versions won't work.

If you are an end-user that uses the module with the included getSchema method you don't have to be worried.

If you use external schema this method will stop you from adding schemas with versions lower than 2.0.0.

https://github.com/TF2Autobot/node-tf2-schema-2/blob/414bb508de77e4861a4de2fe41424ffb307e12b0/index.js#L71-L75

Invalid javascript?

https://github.com/TF2Autobot/node-tf2-schema-2/blame/5fb25ebcb325a5cc0f7498a66bfa7dd1e1115a84/lib/schema.js#L723

On master branch of autobot this line gives me:

"C:\Program Files\nodejs\node.exe" C:\tf2autobot\dist\app.js
2021-03-22 22:26:09 warn: You are not running the bot with PM2! If the bot crashes it won't start again. Get a VPS and run your bot with PM2: https://github.com/TF2Autobot/tf2autobot/wiki/Getting-a-VPS
C:\tf2autobot\node_modules\tf2-schema-2\lib\schema.js:648
            item.quality = item.quality ?? schemaItem.item_quality; //default quality
                                         ^

SyntaxError: Unexpected token '?'

TODO: Fix defindex for Exclusive Genuine items

Genuine Fear Monger should be 30739;1.

https://github.com/TF2Autobot/node-bptf-listings-2/blob/c12d2fbc9cee319577f5f8a271e82038c3cb726a/classes/listing.js#L329-L374