ifsmirnov/game-solver

game-solver's Issues

Third-party libraries used

X-clicker cannot be compiled until libxdo-dev is installed on my PC. -lxdo -lX11 flags should be added to ld to link successfully.
I don't like it. The project should be solid, shouldn't it? Are there any common methods to avoid such non-standard libraries, or we say that dependencies are OK? For example, all libxdo code might be included in our repo, but this doesn't seem to be a good practice either.

Dynamic_cast<> vs. const

In some methods e.g. AppActionExecutor::execute (), as arguments used const pointers, but it's impossible to use dynamic_cast with const pointers.

Private fields

In some basic class such as AppState there are private fields, which should be set in inherited classes. Mb we should change it "protected"