igeligel/skadisteam.login

:snowflake: A package to login into steamcommunity.com via a .net core wrapper. This will not need an api key because it is using the methods which steam is providing via the web.

skadisteam.login's Issues

SteamId Parse

In SkadiLoginResponseFactory the id is required to be a long. If the id is a custom url we should rather get the SteamID out of a cookie rather than doing one extra request then.

Session normalization

Should we explicitly set the default language to english?

session.Cookies.Add(new Cookie("Steam_Language", "english"));

Does Steam remember languages on a per-user basis or based on IP location?

Time aligner for right two factor codes

Add time aligner like here.

Password Encryption on Linux

Password Encryption is not working on Linux.
Checkout EncryptPasswordFactory to resolve this issue.

When running the tests i get this error:

System.PlatformNotSupportedException

Stacktrace:

Stack Trace:
           at System.Security.Cryptography.RSACryptoServiceProvider..ctor()
        /home/kevin/programming/github/skadisteam.login/src/skadisteam.login/Factories/EncryptPasswordFactory.cs(23,0): at skadisteam.login.Factories.EncryptPasswordFactory.EncryptPassword(EncryptPasswordModel encryptPasswordModel)
        /home/kevin/programming/github/skadisteam.login/src/skadisteam.login/Factories/EncryptPasswordFactory.cs(18,0): at skadisteam.login.Factories.EncryptPasswordFactory.Create(GetRsaKeyResponse getRsaKeyResponse, String password)
        /home/kevin/programming/github/skadisteam.login/src/skadisteam.login.test/Factories/EncryptPasswordTest.cs(29,0): at skadisteam.login.test.Factories.EncryptPasswordTest.Length()

Other stacktrace:

skadisteam.login.test.Factories.EncryptPasswordTest.Format [FAIL]
      System.PlatformNotSupportedException : Operation is not supported on this platform.
      Stack Trace:
           at System.Security.Cryptography.RSACryptoServiceProvider..ctor()
        /home/kevin/programming/github/skadisteam.login/src/skadisteam.login/Factories/EncryptPasswordFactory.cs(23,0): at skadisteam.login.Factories.EncryptPasswordFactory.EncryptPassword(EncryptPasswordModel encryptPasswordModel)
        /home/kevin/programming/github/skadisteam.login/src/skadisteam.login/Factories/EncryptPasswordFactory.cs(18,0): at skadisteam.login.Factories.EncryptPasswordFactory.Create(GetRsaKeyResponse getRsaKeyResponse, String password)
        /home/kevin/programming/github/skadisteam.login/src/skadisteam.login.test/Factories/EncryptPasswordTest.cs(17,0): at skadisteam.login.test.Factories.EncryptPasswordTest.Format()
  Finished:    skadisteam.login.test

Possible solution described here:

• http://stackify.com/15-lessons-learned-while-converting-from-asp-net-to-net-core/

Test System:

• Ubuntu 16.04
• .netcore 1.1.0
• netstandard 1.6

Add unit and integration tests

Use Coveralls for test coverage.

Steam Two Factor Code

Check if the Code is transmitted in lowercase/uppercase in requests. Probably some steam related error.

Refactor DoLoginResponseValidator

Code could be easily refactored in this method to a single return statement. Example can be found here.

if (doLoginResponse.Success && doLoginResponse.LoginComplete)
{
    return true;
}
return false;

Can be resolved to:

return (doLoginResponse.Success && doLoginResponse.LoginComplete);

Add continuous integration

Add appveyor or travis to the project.

Move models out of the library

Move classes out of the library so it is used by the shared library.

The following classes need to be moved:

• SkadiLoginResponse
• ISkadiLoginResponse