igorkulman/iossampleapp

Sample iOS app demonstrating Coordinators, Dependency Injection, MVVM, Binding

iossampleapp's Issues

Restore ViewControllers state

Is it possible to restore ViewController state after terminate app by system?
If I use coordinator pattern app always starts from the beginning.

Migrate from Carthage to Swift Package Manager

It is about time with Carthage being basically dead.

Releasing child coordinators

Hi Igor,

Thanks for sharing this repo, lots of good stuff! I wasn't sure where to ask you a question regarding the code so I'll add an issue, hope that's okay.

Regarding releasing the child coordinators in the AppCoordinator, is there a reason you don't clean up the other child coordinator when switching view's? eg: childCoordinators[.setup] = nil

And I was wondering, in the FeedCoordinator, you check if it's transitioning from the setup (with !navigationController.viewControllers.isEmpty. Wouldn't it be better to check this in the AppCoordinator to separate out the responsibilities better? The FeedCoordinator does not need to know anything about the setup right?

Oh and I like your child-coordinator enums a lot, will use this for my next project!

Cheers!

Project not building on Xcode 11.4

I am trying build project on Xcode 11.4

the carthage update failing you can see the below.

I also have this warning "Incompatible Swift version - framework was built with 5.1 (swiftlang-1100.0.270.13 clang-1100.0.33.7) and the local version is 5.2 (swiftlang-1103.0.32.1 clang-1103.0.32.29)."

Is there something we can do to fix it?

*** Checking out Nuke at "8.4.2"
*** Checking out Reusable at "4.1.1"
*** Checking out Quick at "v2.2.0"
*** Checking out FeedKit at "9.1.0"
*** xcodebuild output can be found in /var/folders/rx/mby_9bp11g98xr3ds6st2fxw0000gn/T/carthage-xcodebuild.L8y03x.log
*** Downloading Reusable.framework binary at "4.1.1"
*** Downloading RxSwift.framework binary at "Catalyst.1"
*** Skipped installing Reusable.framework binary due to the error:
"Incompatible Swift version - framework was built with 5.1 (swiftlang-1100.0.270.13 clang-1100.0.33.7) and the local version is 5.2 (swiftlang-1103.0.32.1 clang-1103.0.32.29)."

Falling back to building from the source

*** Building scheme "CRToast" in CRToast.xcodeproj
*** Building scheme "FeedKit iOS" in FeedKit.xcodeproj
*** Building scheme "Nimble-iOS" in Nimble.xcodeproj
*** Building scheme "Nuke" in Nuke.xcodeproj
*** Building scheme "Quick-iOS" in Quick.xcworkspace
*** Building scheme "Reusable-iOS" in ReusableDemo.xcworkspace
*** Building scheme "RxNuke" in RxNuke.xcodeproj
*** Building scheme "RxSwiftExt-iOS" in RxSwiftExt.xcworkspace
*** Building scheme "SpecLeaks" in SpecLeaks.xcodeproj
Build Failed
Task failed with exit code 65:
/usr/bin/xcrun xcodebuild -project /Users/mg/iOSProjects/iOSSampleApp/Sources/Carthage/Checkouts/specleaks/SpecLeaks.xcodeproj -scheme SpecLeaks -configuration Release -derivedDataPath /Users/mg/Library/Caches/org.carthage.CarthageKit/DerivedData/11.4_11E146/specleaks/0.1.8 -sdk iphoneos ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/rx/mby_9bp11g98xr3ds6st2fxw0000gn/T/specleaks SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/mg/iOSProjects/iOSSampleApp/Sources/Carthage/Checkouts/specleaks)

Single responsability

I think that saving the user data, for example the onBoardingData should be responsability of the ViewModel, what do you think?. Nice project btw!

Use Fastlane also for Carthage bootstrap

Add Fastlane action to generate app screenshots

Bootstrap script does not actually install the dependencies

Just updates then. Also Fastlane is better installed as gem.