igorski/vstsid

VST plugin version of the WebSID Commodore 64 synthesizer

vstsid's Issues

.clap plugin support?

Does not work in latest Reaper 6.78

Nor VST2 nor VST3
no Sound at all
only Spikes when moving the ringmodulator slider

Unable to build for Linux: No rule to make target `vst3sdk/build/lib/Release/libbase.a`

Build log:

Flushing build caches and output folders
Creating build folders
Building project
----------------
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- [SMTG] Linux architecture name is x86_64-linux.
-- [SMTG] SMTG_PLUGIN_TARGET_PATH is set to: /home/dreamer/.vst3
-- Found X11: /usr/include   
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so
-- Looking for XOpenDisplay in /usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found Freetype: /usr/lib/x86_64-linux-gnu/libfreetype.so (found version "2.12.1") 
-- Found PkgConfig: /bin/pkg-config (found version "1.8.1") 
-- Checking for module 'xcb'
--   Found xcb, version 1.15
-- Checking for module 'xcb-util'
--   Found xcb-util, version 0.4.0
-- Checking for module 'xcb-cursor'
--   Found xcb-cursor, version 0.1.4
-- Checking for module 'xcb-keysyms'
--   Found xcb-keysyms, version 0.4.0
-- Checking for module 'xcb-xkb'
--   Found xcb-xkb, version 1.15
-- Checking for module 'xkbcommon'
--   Found xkbcommon, version 1.5.0
-- Checking for module 'xkbcommon-x11'
--   Found xkbcommon-x11, version 1.5.0
-- Configuring done
-- Generating done
-- Build files have been written to: /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/build
[  5%] Generating VST3/vstsid.vst3/Contents/Resources/version.png
[SMTG] Copied /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/resource/version.png to /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/build/VST3//vstsid.vst3/Contents/Resources/version.png
[ 10%] Generating VST3/vstsid.vst3/Contents/Resources/background.png
[SMTG] Copied /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/resource/background.png to /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/build/VST3//vstsid.vst3/Contents/Resources/background.png
[ 15%] Generating VST3/vstsid.vst3/Contents/Resources/plugin.uidesc
[SMTG] Copied /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/resource/plugin.uidesc to /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/build/VST3//vstsid.vst3/Contents/Resources/plugin.uidesc
[ 20%] Generating VST3/vstsid.vst3/Contents/Resources/slider_background.png
[SMTG] Copied /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/resource/slider_background.png to /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/build/VST3//vstsid.vst3/Contents/Resources/slider_background.png
[ 25%] Generating VST3/vstsid.vst3/Contents/Resources/slider_handle.png
[SMTG] Copied /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/resource/slider_handle.png to /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/build/VST3//vstsid.vst3/Contents/Resources/slider_handle.png
[ 30%] Generating VST3/vstsid.vst3/Contents/Resources/slider_handle_2.0x.png
[SMTG] Copied /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/resource/slider_handle_2.0x.png to /home/dreamer/Sources/_audio/_plugins/_igorski/VSTSID/build/VST3//vstsid.vst3/Contents/Resources/slider_handle_2.0x.png
[ 35%] Building CXX object CMakeFiles/vstsid.dir/src/lfo.cpp.o
[ 40%] Building CXX object CMakeFiles/vstsid.dir/src/filter.cpp.o
[ 45%] Building CXX object CMakeFiles/vstsid.dir/src/ringmod.cpp.o
[ 50%] Building CXX object CMakeFiles/vstsid.dir/src/synth.cpp.o
[ 55%] Building CXX object CMakeFiles/vstsid.dir/src/vst.cpp.o
[ 60%] Building CXX object CMakeFiles/vstsid.dir/src/vstentry.cpp.o
[ 65%] Building CXX object CMakeFiles/vstsid.dir/src/ui/controller.cpp.o
[ 70%] Building CXX object CMakeFiles/vstsid.dir/home/dreamer/Sources/_audio/_plugins/vst3sdk/public.sdk/source/common/commoniids.cpp.o
[ 75%] Building CXX object CMakeFiles/vstsid.dir/home/dreamer/Sources/_audio/_plugins/vst3sdk/public.sdk/source/vst/vstaudioeffect.cpp.o
[ 80%] Building CXX object CMakeFiles/vstsid.dir/home/dreamer/Sources/_audio/_plugins/vst3sdk/vstgui4/vstgui/vstgui_uidescription.cpp.o
In file included from /home/dreamer/Sources/_audio/_plugins/vst3sdk/vstgui4/vstgui/vstgui_uidescription.cpp:7:
/home/dreamer/Sources/_audio/_plugins/vst3sdk/vstgui4/vstgui/uidescription/compresseduidescription.cpp:31:7: warning: ‘VSTGUI::ZLibInputStream’ has a field ‘VSTGUI::ZLibInputStream::zstream’ whose type uses the anonymous namespace [-Wsubobject-linkage]
   31 | class ZLibInputStream : public InputStream
      |       ^~~~~~~~~~~~~~~
/home/dreamer/Sources/_audio/_plugins/vst3sdk/vstgui4/vstgui/uidescription/compresseduidescription.cpp:49:7: warning: ‘VSTGUI::ZLibOutputStream’ has a field ‘VSTGUI::ZLibOutputStream::zstream’ whose type uses the anonymous namespace [-Wsubobject-linkage]
   49 | class ZLibOutputStream : public OutputStream
      |       ^~~~~~~~~~~~~~~~
[ 85%] Building CXX object CMakeFiles/vstsid.dir/home/dreamer/Sources/_audio/_plugins/vst3sdk/vstgui4/vstgui/plugin-bindings/vst3editor.cpp.o
[ 90%] Building CXX object CMakeFiles/vstsid.dir/home/dreamer/Sources/_audio/_plugins/vst3sdk/public.sdk/source/vst/vstguieditor.cpp.o
[ 95%] Building CXX object CMakeFiles/vstsid.dir/home/dreamer/Sources/_audio/_plugins/vst3sdk/public.sdk/source/main/linuxmain.cpp.o
make[2]: *** No rule to make target '/home/dreamer/Sources/_audio/_plugins/vst3sdk/build/lib/Release/libbase.a', needed by 'VST3/vstsid.vst3/Contents/x86_64-linux/vstsid.so'.  Stop.
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/vstsid.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
An error occurred during build of plugin

Build error: 'SHRT_MAX' is defined in header '<climits>'; did you forget to '#include <climits>'?

/src/synth.cpp:28:1: note: 'SHRT_MAX' is defined in header '<climits>'; did you forget to '#include <climits>'?

I got this error when building for linux.
I added #include <climits> as suggested and it worked.

FYI

Update:
When running it in Bitwig it crashes with this:

Contents/x86_64-linux/vstsid.so: undefined symbol: pango_layout_set_text

...that's pretty much how deep I can go ;)

Activation and adjusting of ring modulator value is noisy

...nasty clicks occur when the ring modulators value changes, this should be less abrasive.

[Feature request] StudioRack integration

It's an open-source plugin manager called StudioRack:
https://github.com/studiorack

The aim of the project is to provide a free open-source way to manage plugin dependencies and their versions. It would involve the following steps:

Publish a Github release containing the plugin source along with metadata plugins.json
Tag your Github repository with studiorack-plugin so it can be discovered
Wait for the studiorack-registry to index your plugin (every 24 hours)
Check the registry feed for your plugin to appear