iisaduan/ts-fix

ts-fix's Issues

Log version of TypeScript used

You can get this from project.ts.version

Running tests changes source code

It's because cli.ts has side effects (running codefixes), but you try to import makeOptions from it. So when the import gets evaluated, it's like you're actually running the CLI. You should separate makeOptions (and anything else you could need to import) into a different file.

Multipass runs don’t work with TestHost

We're not actually writing files, but on the second pass, the TS project reads the original files from disk instead of reading our virtual changes. We need to make TS read those virtual changes.

Require `--write` flag to emit files

Make integration test names more descriptive

Add descriptive error handling of `createProject`

Move `cwd` out of tests

Add usage guide on README and improve --help

CLI does nothing

Missing () here to actually call the anonymous async function:

ts-fix/src/cli.ts

Line 101 in 74b8516

}) ;

Require a fix name / error code

I think we should do away with the default of applying all available fixes. It’s bound to produce a ton of undesired changes.

Tests fail on macOS/Linux

This is what I get on my machine:

  ● option_empty_argv

    expect(received).toEqual(expected) // deep equality

    Expected: "/Users/anbranc/Developer/microsoft/TS-transform-project/C:\\TSuser\\src\\tsconfig.json"
    Received: "/Users/anbranc/Developer/microsoft/TS-transform-project/C:\\TSuser\\src/tsconfig.json"

Both the expected and received look fishy to me. We should probably avoid hard-coding Windows-style paths into tests as they’ll behave differently on different OSes.

Rethink fixing by error code and fixName

interface I {}

declare const obj: I;

obj.foo;
//  ^^^ Property 'aa' does not exist on type 'I'.ts(2339)

This error returns two fixes:

For each, the fixName is fixMissingMember. They represent two different ways of fixing the same thing. I believe the current code will try to apply them both. Unfortunately, there’s not actually a way to differentiate them besides their description property, which is dynamic.

A minimal fix, probably good enough to start with, would be to only apply the first fix returned for a given error, since we try to sort the most likely fixes first. If we need more granularity, we’d need an API change from TypeScript itself.

Rename `ts-fix`

TS program can’t find default lib files

The number of diagnostics the tool reports is way higher than what tsc -p reports because the LS host seems to have a wrong implementation of getDefaultLibFileName.

Incorrect equality comparison

This will never be true since arrays are compared by reference equality. I don’t think the condition is needed, though?

ts-fix/src/index.ts

Line 70 in 90a7e5c

if (diagnosticsPerFile === [] || diagnosticsPerFile === [[]]){

Add repositories for integration testing

addMissingMember integration test needs fixing

It’s a multi-pass one and it only shows one update right now.

Set up CI

New Flag for console output