ikoote1/leaderboard

Hi, I am ikoote

Computer Engineer | Full Stack Developer | Web Designer | Technical Writer | Mentor

---

Experienced engineer & full-stack developer passionate about open-source. Skilled in coding, networking, testing & user-friendly designs. Proficient in various languages, unit testing, frameworks & cutting-edge tech. An agile learner with proven remote work excellence. Strong problem-solving abilities & communication skills.

Contact me on:

Email: [email protected]

Linkedin

Portfolio

leaderboard's Issues

Peer to peer code review

Great job in writing this amazing code. however, after reviewing your project, there are a few suggestions we would like you to consider.

• can we use a type = "number" on the score for the input? This would make the application more practical and prevent logical errors in data handling.
  

  Leaderboard/src/index.html

  Line 26 in 4ae894e

  <input type="text" name="score" class="your-score" placeholder="Your score">

• consider adding a required attribute to your input elements to make it impossible for users to submit empty data
  

  Leaderboard/src/index.html

  Lines 25 to 26 in 4ae894e

  	<input type="text" name="user" class="name" placeholder="Your name">
  	<input type="text" name="score" class="your-score" placeholder="Your score">

• The leaderboard should be able to sort the users' data based on their scores in descending order. consider using the array.sort() function as shown below:
  arr = arr.sort((a, b) => a - b)

• Kindly consider refactoring all functions defined with the 'function' keyword. Try using arrow functions instead like shown below:
  

  Leaderboard/src/index.js

  Lines 17 to 33 in 4ae894e

  	function addData(event) {
  	event.preventDefault();
  	const formData = new FormData(form);
  	const data = Object.fromEntries(formData);
  	const jsonData = JSON.stringify(data);
  	fetch('https://us-central1-js-capstone-backend.cloudfunctions.net/api/games/2gzeEkv7rMvQMPeB1pjG/scores/', {
  	method: 'POST',
  	body: jsonData,
  	headers: {
  	'Content-type': 'application/json; charset=UTF-8',
  	},
  	})
  	.then((response) => response.json())
  	.then((json) => console.log(json));
  	}

  
  const addData = event => { };