ilgarmehmetali/budgie-pixel-saver-applet

Abandoned

Budgie Pixel Saver

This applet hides the title bar from maximized windows and creates a new one inside the panel. Inspired from gnome extension pixel-saver.

• Added settings to choose action buttons and title bar visibility. This way its possible to create different layouts with multiple applets.
• Added settings to set title length.

---

Dependencies

budgie-1.0 >= 2
gnome-desktop-3.0
gtk+-3.0 >= 3.18
gdk-x11-3.0
glib-2.0
libpeas-1.0 >= 1.8.0
libwnck-3.0 >= 3.14.0
vala
xprop

Installing

From source

mkdir build && cd build
meson --prefix /usr --buildtype=plain ..
ninja
sudo ninja install

License

This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or at your option) any later version.

Workspaces applet of Budgie Desktop is used as a templete for this project. Spacer applet used as a templete in implementing settings.

budgie-pixel-saver-applet's Issues

New update (31/12/18) causes panel to partially cover menu items

I am using the Pixel Saver applet on a top panel in Ubuntu Budgie. With today's update (Dec 13, 2018), the top panel now partially covers the top of the application window (including menu items) when the applet is showing. It seems that the new update introduces a forced panel height (of 45 px, possibly?). When using a panel that is less than this height (mine is 30 px), the Pixel Saver applet appears to override the height.

missing license file / public email address

please can you add a license file for this project.

I wish to package this for Ubuntu Budgie - and I need this to create a valid package.

Also I note you do not have a public email address in the plugin file. You don't have to - but again, for debian packaging it is usual to give full acknowledgment of you as the author.

Use the custom order of the Window Action buttons (Close, Max, Min vs Close, Min, Max)

Some users, like myself, use the Close, Min, Max button order, but when we maximize using this applet it always changes the order to Close, Max, Min. This ought to be dynamic and check against the dconf/gsettings value before statically setting the order.

Window snapping (to sides) doesn't work right

When I snap a window to one side of the screen, its title bar disappears, but the window doesn't show up in the applet.

geany opens with a blank space for the decoration

from terminix - if I run geany it opens maximized but with a blank space for the decoration.
if I unmaximized and maximize the decoration correctly disappears into the panel.

Do not hide maximized windows title in 19.04

Hi!
(sorry my ugly English)
New installation of Budgie 19.04.
Two pixel saver applet on top panel (for window title and buttons).
Do not hide maximized window own title.

assertion previous window != NULL

noticed the above error in a terminal - run budgie-panel --replace and then open an app.

CSD apps should not be displayed by pixel saver

suggestion - there is not a lot of benefit for pixel saver to display anything for CSD based apps

[feature request] Left aligned buttons?

Hi thanks for the applet, been considering moving to budgie and pixel saver was one of the things holding me back. It would be nice to have the option to change the layout for left aligned windows.

Thanks again for the applet.

Need to review if the way im getting x11 server time for window closing is correct

Support for vertical panels

When using the applet with a vertical panel (on the left or on the right), the panel becomes too wide. Maybe an option to only show the close button?

window borders in ulauncher

when the applet is enabled it causes to form window borders in ulauncher, how to resolve this situation

Use theme styled buttons

Hi,
don't you think it would be good, buttons to use the style of the current theme?
Is this possible and how hard it will be to implement?

Panel crash when adding the applet..

Active window stays null after closing guake window.

reentrancy assertion

open raven - then click back on terminix - raven closes and you see the error message in the screenshot

Gnome apps' window breaks when using pixel saver.

When the Pixel Saver applet is added to the panel, regardless of the setting used, Gnome apps like Software, Nautilus (file manager), Image Viewer, Gnome Clocks etc. have two window bars instead of one. This makes the application have two window bars, and leaves a large empty space which cannot be clicked through, nor allow the Gnome app to extend past.

Note how in the image the desktop background is visible through the themed title bar (from the GTK theme) , but also shows the Gnome app's title bar in the window. This empty space makes it hard to multi task because now there is unnecessary padding on every Gnome window

Again note how the window behind it (which is Vesktop) is visible through the Gnome app.
More examples of Gnome Apps breaking

Note : When the app is full screened, it works as intended, except the fact that Gnome apps' window bar still exists, which would not be a problem because the plugin has an option to disable the panel's window bar if it cannot be removed (Hide for client side decorated windows)

Removing the plugin fixes the problem.

Further details
OS: Arch Linux x86_64
Kernel: 6.8.2-arch1-1
DE: Budgie 10.9.1
WM: Mutter(Budgie)

Note : gnome-console suffers from this issue, but gnome-terminal does not, and I am not sure why.

ninja: error: '../src/src/settings.ui', needed by 'src/budgie-pixel-saver-applet-resources.c', missing and no known rule to make it

meydjer@mpc:~/Downloads/budgie-pixel-saver-applet$ mkdir build && cd build
meydjer@mpc:~/Downloads/budgie-pixel-saver-applet/build$ meson --prefix /usr --buildtype=plain ..
The Meson build system
Version: 0.44.0
Source dir: /home/meydjer/Downloads/budgie-pixel-saver-applet
Build dir: /home/meydjer/Downloads/budgie-pixel-saver-applet/build
Build type: native build
Project name: budgie-pixel-saver-applet
Native C compiler: cc (gcc 5.4.0)
Native Vala compiler: valac (valac 0.30.1)
Build machine cpu family: x86_64
Build machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Native dependency gtk+-3.0 found: YES 3.18.9
Native dependency gdk-x11-3.0 found: YES 3.18.9
Native dependency glib-2.0 found: YES 2.48.2
Native dependency libpeas-1.0 found: YES 1.16.0
Native dependency budgie-1.0 found: YES 2
Native dependency libwnck-3.0 found: YES 3.14.1
Native dependency glib-2.0 found: YES 2.48.2
WARNING: GLib compiled dependencies do not work reliably with 
the current version of GLib. See the following upstream issue: https://bugzilla.gnome.org/show_bug.cgi?id=774368
Program meson_post_install.py found: YES (/usr/bin/env python3 /home/meydjer/Downloads/budgie-pixel-saver-applet/meson_post_install.py)
Build targets in project: 4
Found ninja-1.8.2 at /usr/bin/ninja
meydjer@mpc:~/Downloads/budgie-pixel-saver-applet/build$ ninja
ninja: error: '../src/src/settings.ui', needed by 'src/budgie-pixel-saver-applet-resources.c', missing and no known rule to make it
meydjer@mpc:~/Downloads/budgie-pixel-saver-applet/build$ sudo ninja install
ninja: error: '../src/src/settings.ui', needed by 'src/budgie-pixel-saver-applet-resources.c', missing and no known rule to make it
meydjer@mpc:~/Downloads/budgie-pixel-saver-applet/build$

need to install into plugin subfolder

you'll note that Ikey has restructured budgie-desktop 10.3

all plugins now install into their own subfolder under plugins

thus I would recommend installing the plugin in

/usr/lib/budgie-desktop/plugins/budgie-pixel-saver-applet/

Spotify covers entire screen when maximized

Spotify for Linux, when maximized with this applet active, covers the entire screen, including the panel.

I can alt-tab between apps, etc, but I can't see the panel until I reset budgie nohup budgie-panel --replace& (and if I focus on Spotify after that, it covers the panel again).

My current work-around is to move to a new desktop, start Spotify there, then switch back to my main desktop. So this isn't ultra-urgent. But let me know if you need anything from me (logs etc.) to help nail this down.

Thanks for my favorite budgie app!

Blacklisting Applications

I use firefox with client side decorations and pixel saver shows its buttons so window Buttons are shown double. It does this not on gnome Apps so this is a problem with firefox.... Can you solve this problem with a user editable blacklist for instance?

Build with arch

Hi,
i have problems to build it with arch_linux
I get this error:
Meson encountered an error in file meson.build, line 36, column 0:
Could not generate cargs for libpeas-1.0:
And the meson log:
Build started at 2017-12-23T17:11:04.591678
Main binary: /usr/bin/python
Python system: Linux
The Meson build system
Version: 0.44.0
Source dir: /home/reinhard/Downloads/budgie-pixel-saver-applet-master
Build dir: /home/reinhard/Downloads/budgie-pixel-saver-applet-master/build
Build type: native build
Project name: budgie-pixel-saver-applet
Sanity testing C compiler: cc
Is cross compiler: False.
Sanity check compiler command line: cc /home/reinhard/Downloads/budgie-pixel-saver-applet-master/build/meson-private/sanitycheckc.c -o /home/reinhard/Downloads/budgie-pixel-saver-applet-master/build/meson-private/sanitycheckc.exe
Sanity check compile stdout:

---

Sanity check compile stderr:

---

Running test binary command: /home/reinhard/Downloads/budgie-pixel-saver-applet-master/build/meson-private/sanitycheckc.exe
Native C compiler: cc (gcc 7.2.1)
Running compile:
Working directory: /tmp/tmp0e1nhq76
Command line: valac /tmp/tmp0e1nhq76/testfile.vala -C -C -o /tmp/tmp0e1nhq76/output.obj

Code:
class MesonSanityCheck : Object { }
Compiler stdout:
Compilation succeeded - 1 warning(s)

Compiler stderr:
warning: --output and -o have no effect when -C or --ccode is set

Native Vala compiler: valac (valac 0.38.4)
Build machine cpu family: x86_64
Build machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29.2)
Determining dependency 'gtk+-3.0' with pkg-config executable '/usr/bin/pkg-config'
Native dependency gtk+-3.0 found: YES 3.22.26
Determining dependency 'gdk-x11-3.0' with pkg-config executable '/usr/bin/pkg-config'
Native dependency gdk-x11-3.0 found: YES 3.22.26
Determining dependency 'glib-2.0' with pkg-config executable '/usr/bin/pkg-config'
Native dependency glib-2.0 found: YES 2.54.0
Determining dependency 'libpeas-1.0' with pkg-config executable '/usr/bin/pkg-config'

Any ideas?

figure out how to do window dragging from title bar

100% CPU and black screen

Hello!
After adding pixel saver to panel, application from Steam Play( wine from steam ) start with a black screen and 100% CPU utilization. And after nothing happens.
Ubuntu Budgie 19.04

non maximized windows should not display in the panel

apps that are not maximized you still see the window controls - suggest hide these from the panel.

xprop not listed as a dependency

As the title says. Found it in my crash log, installed xprop, working extension.

super wide raven when opening settings

I'm trying to get the plugin to work under Ubuntu 16.04 - it uses GTK+3.18

I've reduced the settings.ui setting from GTK+3.20 to GTK+3.18

It compiles and works very well under Ubuntu 16.04 - the only problem is when I open settings raven expands hugely. Any ideas?

Buttons so strange in top panel

My buttons are stranger in top panel, I can edit them?, how?

DESKTOP BUDGIE 10.3.1-0ubuntu0.5~zesty
(Ubuntu Budgie 17.04 zesty)

Theme: ADAPTA - Material design

when removing the applet from the panel, it appears still to be partially working

I removed the applet from the window - the window decoration didnt reappear - minor issue.

However, when closing the app and reopening the decoration still does not display until you logout/login or run budgie-panel --replace

Some Programs are not Unmaximizable if Maximized

Some Programs do not have the option to click and drag the title bar, it works for Chrome but this does not work for Qt Creator and more.

Solution would be to make it like Unity, click and Drag the Pixel Saver widget to unmaximize a window

Window buttons not using theme styles

Hi there,
I'm not sure if this is a bug or a feature request, but when implementing pixel saver (Ubuntu Budgie), the window buttons (close/maximise/minimise) seem to ignore the theming. Is this due to a bug or something to be implemented?