iljah/hdintegrator

hdintegrator's Issues

local library / include path location

Can you possibly change the Makefile and/or document how to pick up the installed GSL files?

I had to set these environment variables to get passed:

export CPATH=/opt/local/include
export LIBRARY_PATH=/opt/local/lib

tabs vs spaces

Do you have any reason to use tabs instead of spaces?

It gave me a hard time to make the changes you suggested on #13.

Also see https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces

installation is not really documented

The INSTALL provides some details about the software requirements, but doesn't actually specify how to install the hdintegrator software itself.

recommend virtual environments in installation procedure

Instead of having people mess up their system environment, I would suggest you document the installation using virtual environments (or anaconda's equivalent).

use markdown for readme, install, etc

Please use markdown to increase the readability of the documentation.

document installation of cubature

license file is called COPYING instead of LICENSE

provide better description of which kind of problems I can use this software for

ld: library not found for -lboost_program_options

Which dependency is missing here?

$ make
g++ -std=c++14 -O3 -march=native -W -Wall -Wextra -Wpedantic integrands/burgers.cpp -o integrands/burgers_plain integrands/gsl/plain2.c -DMETHOD=1 -I integrands/gsl -lgsl -lgslcblas -lboost_program_options
clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is deprecated [-Wdeprecated]
ld: library not found for -lboost_program_options
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [integrands/burgers_plain] Error 1

usage documentation largely missing

Please provide information like:

• arguments
• options
• input formats

split out python vs non-python

Given the complexity of installing the non-python bits, I would suggest splitting the two up.

The first part of the documentation would then be roughly:

• setup the virtual env
• pip install hidintegrator
• the python usage examples, e.g. mpiexec -n 4 hdintegrator.py --integrand integrands/N-sphere.py --dimensions 2 (pointing out that need those files obviously)

And then continue, "for increased performance, one can install C++ versions of the integrands ..."

That at least gets your users with something attainable.

N-sphere integrand fails

$ mpiexec -n 2 ./hdintegrator.py --integrand integrands/N-sphere --dimensions 15 --prerefine 200
Traceback (most recent call last):
  File "./hdintegrator.py", line 356, in <module>
    split(choice(grid.get_cells()), 1, [randint(0, len(dimensions) - 1)], grid)
  File "/Users/mark/Desktop/review/ve/lib/python3.6/random.py", line 258, in choice
    return seq[i]
  File "/Users/mark/Desktop/review/ve/lib/python3.6/site-packages/networkx/classes/reportviews.py", line 178, in __getitem__
    return self._nodes[n]
KeyError: 0
^C(ve) netbook:hdintegrator mark$ 

It hangs after the error and I had to ctrl-c it.

pypi package

Is there a reason not to provide a pypi package?
I generally consider that a good practice.

no (documented) tests available