Giter Site home page Giter Site logo

omniauth-mailru's People

Contributors

ilya-konanykhin avatar

Watchers

 avatar

Forkers

bekseitn

omniauth-mailru's Issues

Not correct callback url

You use not correct method

def callback_url
  options.callback_url || super
end

When super used. It calls from OmniAuth::Strategy

def callback_url
   full_host + script_name + callback_path + query_string
end

query_string is extra parameter.
This makes diffrerent redirect_uri on request_phase and callback_phase.

  1. Request phase:
    redirect_uri: http://localhost:3000/auth/mailru/callback

  2. Callback phase:
    redirect_uri: http://localhost:3000/auth/mailru/callback?state=some_state&code=some_code

It returns:
{"error_description":"USER_DATA_FAIL","error":"invalid_grant"}

I just patch it:

class OmniAuth::Strategies::Mailru 
  def callback_url
    options.callback_url || (full_host + script_name + callback_path)
  end
end

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.