imbios/next-pwa

Zero config PWA plugin for Next.js, with workbox 🧰 with appDir support

next-pwa's Issues

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency syncpack to v10
• chore(deps): update dependency typescript to v5
• chore(deps): update lint (major) (@typescript-eslint/eslint-plugin, eslint-config-prettier, prettier)
• fix(deps): update dependency babel-loader to v9
• fix(deps): update dependency globby to v13
• fix(deps): update workbox monorepo to v7 (major) (workbox-webpack-plugin, workbox-window)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

github-actions

.github/workflows/build-examples.yml

• actions/checkout v3
• pnpm/action-setup v2
• actions/setup-node v3

.github/workflows/npm-publish.yml

• actions/checkout v3
• pnpm/action-setup v2
• actions/setup-node v3
• changesets/action v1

nodenv

.node-version

• node 18

npm

docs/package.json

• next 13.4.13
• nextra 2.10.0
• nextra-theme-docs 2.10.0
• react 18.2.0
• react-dom 18.2.0
• @types/node 18.17.4
• typescript 4.9.5

package.json

• @changesets/changelog-github 0.4.8
• @changesets/cli 2.26.2
• @commitlint/cli 17.6.7
• @commitlint/config-conventional 17.6.7
• concurrently 8.2.0
• dotenv-cli 7.2.1
• eslint 8.46.0
• husky 8.0.3
• lint-staged 13.2.3
• prettier 2.8.8
• syncpack 9.8.6
• turbo 1.10.12
• pnpm 8
• node >=16.0.0
• pnpm 8.6.12

packages/config-prettier/package.json

packages/eslint-config-custom/package.json

• eslint-config-next 13.4.13
• eslint-config-prettier 8.10.0
• eslint-config-turbo 1.10.12

packages/next-pwa/package.json

• babel-loader 8.3.0
• clean-webpack-plugin 4.0.0
• globby 11.1.0
• terser-webpack-plugin 5.3.9
• workbox-webpack-plugin 6.6.1
• workbox-window 6.6.1
• webpack 5.88.2
• next >=9.0.0
• @typescript-eslint/eslint-plugin 5.62.0

---

• Check this box to trigger a request for Renovate to run again on this repository

[BUG]:Uncaught (in promise) bad-precaching-response in production

Description of the bug

I am following this tutorial https://next-pwa.imam.dev/usage,
all works fine until I send it to production, then I get this error, any suggestion on how to fix it?

Environment

N/A

Steps To Reproduce

N/A

Additional Information

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
• The provided reproduction is a minimal reproducible of the bug.

[FEAT]: black list api endpoints

Clear and concise description of the problem

We're seeing a lot of double requests on ios lately. Its like the service worker will do a prior request before the "real" request. This invalidates our oauth token which then results in a failed login.

Is there anyway of "black listing" /api/ and telling the sw never to call anything in that space?

{ip} - - [07/Jun/2023:06:38:34 +0200] "GET /api/broker/callback?code={long hash}-1&scope=openid%20mitid&state=login&iss=https%3A%2F%2F{oauth provider}.dk%2Fop HTTP/2.0" 302 0 "https://www.{domain}.dk/sw.js" "Mozilla/5.0 (iPhone; CPU iPhone OS 16_5 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.5 Mobile/15E148 Safari/604.1" "-" [RequestTime: 0.047 - UpstreamTime: 0.048]
{ip} - - [07/Jun/2023:06:38:34 +0200] "GET /api/broker/callback?code={long hash}-1&scope=openid%20mitid&state=login&iss=https%3A%2F%2F{oauth provider}.dk%2Fop HTTP/2.0" 499 0 "-" "Mozilla/5.0 (iPhone; CPU iPhone OS 16_5 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.5 Mobile/15E148 Safari/604.1" "-" [RequestTime: 0.116 - UpstreamTime: -]

Suggested solution

No response

Alternative

No response

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[FEAT]: Add Testing

Clear and concise description of the problem

We currently using build and manual test checking by humans who develop the code. It will be a bunch of work if we need to iterate faster.

Suggested solution

No response

Alternative

No response

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[FEAT]: Migrate to TypeScript for Better Type-safety

Clear and concise description of the problem

Currently, we use JavaScript and TS partially in the examples. We can add better type-safety by using TypeScript for the main package.

Suggested solution

No response

Alternative

No response

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.