in3rsha/learnmeabitcoin-code

Simple code snippets to help you understand how Bitcoin works.

learnmeabitcoin-code's Issues

Transaction data structure description outdated

Hi! Thank you for creating the learnmeabitcoin website, it's been super helpful to me! I started implementing some pieces of Bitcoin to get a better handle on it, and noticed that the transaction data structure described at https://learnmeabitcoin.com/technical/transaction-data is not current, since the Bitcoin core code has this flags field that can appear sometimes.

I wasn't really sure where to report this or if I can just make a PR to update it, so I'm filing this issue hoping you see it. Thanks!

checksum function need sha256 twice?

learnmeabitcoin-code/checksum.rb

def checksum(hex)
  hash = hash256(hex) # Hash the data through SHA256 twice
  return hash[0...8]  # Return the first 4 bytes (8 characters)
end

hash = hash256(hash256(hex))

this is a great repository,love you ( 0 3 0 )

fix the broken URLs we have for SEC1 and SEC2 all over the code base

https://github.com/in3rsha/learnmeabitcoin-code/blob/ce478ead1e9f014ab4865efc147dccd0a4db5b01/lib/ecdsa.rb#L9

Invalid timestamp highlight

Hello! I very much enjoyed your website. While doing some double checking to make sure I understood things, I stumbled upon a UI issue with your blockheader example. The timestamp isnt highlighting the leftmost character. As a result it looks 7 characters long instead of 8. Cheers! Great stuff.

Invalid TXID at the website

Hello Greg, thank you for creating such a great website.
The TXID in the link below is invalid and refers to a false transaction.
https://learnmeabitcoin.com/guide/input
It should be changed from "0d0897966df95d0b8e7a33855a64f7de365e7d17e28f2a05c39806e77d5f9859" to "c1b4e695098210a31fe02abffe9005cffc051bbe86ff33e173155bcbdc5821e3", like other pages.
P.S. I didn't know here is a good place to report this issue or no, but anyway I didn't find anywhere better.

hash256

Where do I find hash256?

checksum.rb:3:in `checksum': undefined method `hash256' for main:Object (NoMethodError)
Did you mean?  hash
	from checksum.rb:7:in `<main>'

Should I be using Digest? Thanks in advance.