Sound sets are duplicated

[incrementis]

Sound sets are duplicated

[Incrementis]

After installation:

• Both sound sets !_DEMO and !_DEMOf can be found in CHARSND.2DA (see screenshot) only once.

• All 17 soundfiles are found only once in the game's sound folder as expected(see screenshot).

• The Strref entries are also found in the dialog.tlk as expected.

[Incrementis]

After deinstallation:

• The Strref entries are still in dialog.tlk as expected.
• The soundfiles are deleted as expected
• CHARSND.2DA does not contain the sound set entries as expected.
• The deinstalled sound sets are not visible and selectable in game as expected.

Searching for the same string in dialog.tlk returns results for other soundsets, such as: see screenshot.

Regarding !_DEMO Soundset e.g. for “Battle Cry 1” no search results were found in dialog.tlk other than the one from the last installation.

This is just a side note and may not be relevant: it seems that strings in "[ ]" brackets are not output to the game console?!

[Incrementis]

More ideas to try:

• Reducing the number of sound files for !_DEMO
• Comment out PRETTY_PRINT_2DA in the code
• Changing the location of the sound files to the WAV folder
• Check “//WRITE INTO CHARSND.2DA” for inappropriate logic

[Incrementis]

• Comment out PRETTY_PRINT_2DA in the code :
  This will only result in the CHARSND.2DA file not being formatted correctly, which will not result in any changes in the game.

• Reducing the number of sound files for !_DEMO:
  Reducing !_DEMO to just elment ("Battle Cry 1") gives the ability to choose the sound sets in the customization settings, but doesn't fix the doublicate.

• Changing the location of the sound files to the WAV folder:
  This doesn't work because the sound set cannot be selected in the character customization.

NOTE:
Manually adding the sound files to the lang folder of the game folder results in the same duplication error. Just a reminder: The sound files were copied for the sound sets !_DEMO and !_DEMOF.
This indicates that there is no error in “//WRITE INTO CHARSND.2DA” code section.

[Incrementis]

Copying only !_DEMO soundset sound files into the game's lang folder results in (see screenshot):

This fixes the issue.

Renaming sound file for !_DEMOFf to !_DUMMYf will result in (see screenshot):

This fixes the issue.

This allows us to narrow down the error to the name of the sound files.

To better understand the error, further name testing is required.

NOTE:
This may not be relevant, but it is interesting how the order of the sound sets changes when more than one sounds set is added.

[Incrementis]

The following names do not lead to any problems (see screenshot):

The following names do not lead to any problems (see screenshot):

Strangely enough, the following names do not lead to any problems (see screenshot):

I expected some duplication here due to the addition of !_DEMOF.

NOTE:
Further investigation is needed.

[Incrementis]

It seems that the number of sound files will result in duplicates. At least it seems to be a factor. If an item in this list for !_DEMO (see screenshot) is deleted, a duplicate will not be created.

NOTE:
Further investigation is needed.
So far we know that the name AND the number of sound files are an important factor to isolate the error.

[Incrementis]

We start with the following sound files:

The sum of files is the same as the previous comment, but the postfix of files is the different. The result is that there is no duplication.

Adding gradualy soundfiles with the postfix:
e ▶️ no duplication
f ▶️ not duplication
g ▶️ duplication
deleting g and adding h ▶️ duplication
deleting h and adding i ▶️ duplication
deleting h and adding i ▶️ duplication
deleting i and adding j ▶️ duplication
deleting j and adding k ▶️ duplication
deleting k and adding l ▶️ duplication
deleting l and adding m ▶️ duplication

The result so far is that based on testing, the following postfixes do not result in duplication:
8, 9, a, b, c, d, e

We also now know that the number of sound files is probably not relevant.
Further investigations are needed.

[Incrementis]

The next test starts with the following files (see screenshot). This creates duplicates. The new test names contain a maximum of 6 characters without the postfixes.

Sound files for !_DEMO remain unchanged, while the naming of sound files for !_DEMOF is changed.

!_DEMF ➡️ no duplication
!_DEM ➡️ no duplication
!_DEF ➡️ no duplication
!_DE ➡️ no duplication
!_DF ➡️ no duplication
!_D ➡️ duplication

This time the duplication affects !_D. The postixes f and b are used for !_D.
Changing the postfix from f to e fixes the duplication. We can assume without testing that the postfixes: 8, 9, a, b, c, d, e do not result in duplicates.

Further investigation is needed.

[Incrementis]

Because this error doesn't break the game. This is solved as follows:

• Recommendation to use at least 4 characters when naming the sound files
• Recommendation to use max 6 characters for naming sound files

Based on the findings at hand, this will significantly reduce the likelihood of duplicate sound sets.