indaplus21/alholmbe-assembly

Interpreter to BBVV

To run the program: Make sure that you have Go installed and then cd into the interpreter folder and type:

"go run . filename"

where filename can be e.g factorial.bbvv

alholmbe-assembly's Issues

Pass

Very well done Alexander!

You are well set for DD1396! How sweet!

I like your solution! Thou I'm curious, why do you parse the code in string, and not use enum representations? Enum types are numerical, thus are a lot more efficient to compare etc. For example:
Your code:

var registerType = []string{"add", "sub", "set", "jeq"}
var jumpType = []string{"j"}
var specialType = []string{"input", "print", "exit"}

As enum types:

type RegisterInstr int
const (
	Add RegisterInstr = iota + 1
	Sub
	Set
	Jeq
)

type JumpInstr int
const J JumpInstr = 1

type SpecialInstr int
const (
	Input SpecialInstr = iota + 1
	Print
	Exit
)

See enum types: https://gosamples.dev/enum/

Your splitIntoLines makes it difficult to acctually trace errors. instructionsAreValid handles the instructions as if there are no empty lines in the source code, which there are. I even found this beauty :)
Your code:

var j int
for j = 1; j < 3; j++ {
	//...
	if /*...*/ {
		fmt.Printf("Error on line %d: Missing '#'\n", j+1)
		//...
	}
}

I suggest that the trimmer function returns a sequence of tuples, whom hold an instruction and the instruction's origin line.

Thank you for your hard work :)