indeedeng/go-groups

Command go-groups is a CLI tool to parse go import blocks, sort, and re-group the imports

go-groups's Issues

go-groups should run gofmt before sorting imports

goimports effectively runs gofmt. go-groups should as well.

Getting 503s when installing go-groups

This started happening again yesterday. Here's a recent failure: https://github.com/depscloud/depscloud/runs/1448351245?check_suite_focus=true

cc. @cnmcavoy

Issues fetching binary over the last few days

I've been having some rather sporadic build failures attributed to failures fetching to groups binary from Indeed:

unrecognized import path "oss.indeed.com/go/go-groups": reading https://oss.indeed.com/go/go-groups?go-get=1: 503 Service Unavailable

Here are two examples from today:

• https://github.com/depscloud/depscloud/runs/1221875124?check_suite_focus=true
• https://github.com/depscloud/depscloud/runs/1221875155?check_suite_focus=true

Support ignoring generated source files

Although most generated source files will produce gofmt-compliant code they will often produce Go source that does not adhere to the go-groups import style. It would be good if go-groups supported an option to detect and ignore generated source files based on the documented comment convention:

^// Code generated .* DO NOT EDIT.$

Imports with inline comments may be sorted incorrectly

An import block with:

import (
	"crypto/md5" //nolint:gosec
	"fmt"
 )

Becomes

import (
	"fmt"
	"crypto/md5" //nolint:gosec
 )

After running go-groups on it. This is not a lexicographical sorting of the imports.

Renaming the default branch from "master" to "main"

The default branch name for repositories created on GitHub is now main. See GitHub guidance

Support cleaning up unused imports

Right now, I find myself needing both this tool and goimports. As far as I can tell, the only thing goimports does that go-groups does not is clean up unused imports. It would be nice if go-groups supported this as it would drop the need for goimports almost entirely.

setup badges in README.md

We can setup badges for

• go report
• travisCI build
• godoc reference
• oss lifecycle
• license

use of go fmt example in the README is incorrect

E.g.

$ go-groups -w ./..
$ go fmt -w ./..
flag provided but not defined: -w
usage: go fmt [-n] [-x] [packages]
Run 'go help fmt' for details.
$ gofmt -w ./..

We should reference gofmt instead of go fmt

go-groups does not respect comments in import block

go version: 1.14.5
go-groups version: 0.0.1

package main

import (
        // example comment
	"fmt"
)

func main() {
	fmt.Println("Hello world")
}

goimports leaves comment while go-groups removes.

Add badges to README.md

Add install.sh script or equivalent

Right now, I need to manually download the binary and move it into position. Can we provide a simple shell script that downloads the binary for the appropriate os/architecture that and places it in the users path?

use golangci-lint to lint & fix linter warnings/errors

title.

go-groups does not respect "dot" imports

go version: 1.14.5
go-groups version: 0.0.1

package main

import (
	"fmt"
	"testing"

	. "github.com/onsi/gomega"
	. "github.com/onsi/ginkgo"
)

func main() {
	fmt.Println("Hello world")

	RegisterFailHandler(Fail)
	RunSpecsWithDefaultAndCustomReporters(&testing.T{},
		"Controller Suite",
		[]Reporter{})
}

goimports properly re-ordered the imports, but go-groups removes the import lines.

Use a real email address in CODE_OF_CONDUCT.md

In CODE_OF_CONDUCT.md, there is no contact email listed, only

[INSERT EMAIL ADDRESS]

There should probably be a real email address.