indunet/fastproto

FastProto is a powerful binary data processing tool.

fastproto's Issues

Avoid really long methods.

Codacy detected an issue:

Message: Avoid really long methods.

Occurred on:

• Commit: 5935bfd
• File: src/main/java/org/indunet/fastproto/TypeAssist.java
• LineNum: 124
• Code: protected static TypeAssist of(Field field) {

Currently on:

• Commit: 32bc6e1
• File: src/main/java/org/indunet/fastproto/TypeAssist.java
• LineNum: 179

The utility class name 'CompressorFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)'

Codacy detected an issue:

Message: The utility class name 'CompressorFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)'

Occurred on:

• Commit: 4c3c834
• File: src/main/java/org/indunet/fastproto/compress/CompressorFactory.java
• LineNum: 14
• Code: public class CompressorFactory {

Currently on:

• Commit: 072b3b2
• File: src/main/java/org/indunet/fastproto/compress/CompressorFactory.java
• LineNum: 30

[final-definition] Move definitions to the end of the file (after the node at line `206`)

Codacy detected an issue:

Message: [final-definition] Move definitions to the end of the file (after the node at line 206)

Occurred on:

• Commit: 0544d31
• File: README.md
• LineNum: 15
• Code: [kafka]: https://github.com/indunet/fastproto/wiki/Work-with-Kafka

Currently on:

• Commit: 32bc6e1
• File: README.md
• LineNum: 15

Unused import - java.util.Date.

Codacy detected an issue:

Message: Unused import - java.util.Date.

Occurred on:

• Commit: a02db28
• File: src/main/java/org/indunet/fastproto/annotation/TimeType.java
• LineNum: 30
• Code: import java.util.Date;

Currently on:

• Commit: 91cd369
• File: src/main/java/org/indunet/fastproto/annotation/TimeType.java
• LineNum: 27

Avoid using a branching statement as the last in a loop.

Codacy detected an issue:

Message: Avoid using a branching statement as the last in a loop.

Occurred on:

• Commit: c9ee8d6
• File: src/test/java/org/indunet/fastproto/kafka/KafkaTest.java
• LineNum: 80
• Code: return;

Currently on:

• Commit: 32bc6e1
• File: src/test/java/org/indunet/fastproto/kafka/KafkaTest.java
• LineNum: 97

[list-item-indent] Incorrect list-item indent: add 2 spaces

Codacy detected an issue:

Message: [list-item-indent] Incorrect list-item indent: add 2 spaces

Occurred on:

• Commit: 902bfbc
• File: README.md
• LineNum: 13
• Code: * Binary serialization & deserialization

Currently on:

• Commit: 12b095a
• File: README.md
• LineNum: 17

Avoid unused local variables such as 'o'.

Codacy detected an issue:

Message: Avoid unused local variables such as 'o'.

Occurred on:

• Commit: 6998213
• File: src/main/java/org/indunet/fastproto/codec/DoubleArrayCodec.java
• LineNum: 55
• Code: val o = CodecUtils.reverse(bytes, offset);

Currently on:

• Commit: 91cd369
• File: src/main/java/org/indunet/fastproto/codec/DoubleArrayCodec.java
• LineNum: 60

Avoid unused local variables such as 'o'.

Codacy detected an issue:

Message: Avoid unused local variables such as 'o'.

Occurred on:

• Commit: 6998213
• File: src/main/java/org/indunet/fastproto/codec/FloatArrayCodec.java
• LineNum: 58
• Code: val o = CodecUtils.reverse(bytes, offset);

Currently on:

• Commit: 91cd369
• File: src/main/java/org/indunet/fastproto/codec/FloatArrayCodec.java
• LineNum: 62

The utility class name 'Decoders' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)'

Codacy detected an issue:

Message: The utility class name 'Decoders' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Constants)'

Occurred on:

• Commit: 34f9aad
• File: src/main/java/org/indunet/fastproto/decoder/Decoders.java
• LineNum: 14
• Code: public class Decoders {

Currently on:

• Commit: 072b3b2
• File: src/main/java/org/indunet/fastproto/decoder/Decoders.java
• LineNum: 30

assertTrue(true) or similar statements are unnecessary

Codacy detected an issue:

Message: assertTrue(true) or similar statements are unnecessary

Occurred on:

• Commit: c9ee8d6
• File: src/test/java/org/indunet/fastproto/kafka/KafkaTest.java
• LineNum: 76
• Code: assertTrue(false);

Currently on:

• Commit: 32bc6e1
• File: src/test/java/org/indunet/fastproto/kafka/KafkaTest.java
• LineNum: 93

Avoid reassigning parameters such as 'byteOffset'

Codacy detected an issue:

Message: Avoid reassigning parameters such as 'byteOffset'

Occurred on:

• Commit: 9c1e84b
• File: src/main/java/org/indunet/fastproto/encoder/ByteEncoder.java
• LineNum: 25
• Code: public void encode(@NonNull byte[] datagram, int byteOffset, byte value) {

Currently on:

• Commit: 32bc6e1
• File: src/main/java/org/indunet/fastproto/encoder/ByteEncoder.java
• LineNum: 41

Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Codacy detected an issue:

Message: Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.

Occurred on:

• Commit: 47540f7
• File: src/main/java/org/indunet/fastproto/graph/Reference.java
• LineNum: 77
• Code: ThreadLocal<Object> value = new ThreadLocal<>();

Currently on:

• Commit: d1680e4
• File: src/main/java/org/indunet/fastproto/graph/Reference.java
• LineNum: 90

Unused import - java.math.BigInteger.

Codacy detected an issue:

Message: Unused import - java.math.BigInteger.

Occurred on:

• Commit: a02db28
• File: src/main/java/org/indunet/fastproto/annotation/UInt64ArrayType.java
• LineNum: 29
• Code: import java.math.BigInteger;

Currently on:

• Commit: 91cd369
• File: src/main/java/org/indunet/fastproto/annotation/UInt64ArrayType.java
• LineNum: 27

Avoid unnecessary comparisons in boolean expressions

Codacy detected an issue:

Message: Avoid unnecessary comparisons in boolean expressions

Occurred on:

• Commit: d0633aa
• File: src/main/java/org/indunet/fastproto/FastProto.java
• LineNum: 72
• Code: if (VersionAssist.validate(datagram, protocolClass) == false) {

Currently on:

• Commit: 32bc6e1
• File: src/main/java/org/indunet/fastproto/FastProto.java
• LineNum: 72

Use one line for each declaration, it enhances code readability.

Codacy detected an issue:

Message: Use one line for each declaration, it enhances code readability.

Occurred on:

• Commit: be3e097
• File: src/test/java/org/indunet/fastproto/decoder/FloatDecoderTest.java
• LineNum: 11
• Code: float pi = 3.141f, e = 2.718f;

Currently on:

• Commit: 2eef0da
• File: src/test/java/org/indunet/fastproto/decoder/FloatDecoderTest.java
• LineNum: 29

@IntegerType field serialization byte array is correct?

import org.indunet.fastproto.FastProto;
import org.indunet.fastproto.annotation.type.IntegerType;
import java.nio.ByteBuffer;
import java.util.Arrays;

public class FastProtoTest {
@IntegerType(0)
private int nameLen = 5;

public static void main(String[] args) {
// Output results: [5, 0, 0, 0]
System.out.println(Arrays.toString(FastProto.toByteArray(new FastProtoTest())));
// toByteArray and parseFrom is right.
System.out.println(
FastProto.parseFrom(FastProto.toByteArray(new FastProtoTest()), FastProtoTest.class)
.nameLen);
// Output results: [0, 0, 0, 5]
System.out.println(Arrays.toString(ByteBuffer.allocate(4).putInt(5).array()));
}
}