Giter Site home page Giter Site logo

Comments (9)

jsternberg avatar jsternberg commented on July 18, 2024

Is this for telegraf?

/cc @sparrc

from influxdata-docker.

AddoSolutions avatar AddoSolutions commented on July 18, 2024

@jsternberg Apologies, yes that is the case!

from influxdata-docker.

sparrc avatar sparrc commented on July 18, 2024

the ipmi_sensors plugin depends on ipmitool, maybe it's just a documentation issue for telegraf.

from influxdata-docker.

AddoSolutions avatar AddoSolutions commented on July 18, 2024

@sparrc That is correct, but the problem is that the docker image needs access to ipmitool in order to use that plugin as said. There is no good way to install ipmitool without it being a part of the docker image.

I am suggesting adding that line above to the Dockerfile itself

from influxdata-docker.

jsternberg avatar jsternberg commented on July 18, 2024

@AddoSolutions I'm not sure if we should be installing other tools to be used with specific plugins as part of the base telegraf image. If there's substantial interest, we can publish plugin images for it being easier for users. At the moment though, you can just build a new docker image from the base image and it would be simple to have that image install the ipmitool.

We don't want to cause a substantial amount of bloat for people who are using the telegraf image for something else.

from influxdata-docker.

sparrc avatar sparrc commented on July 18, 2024

+1, we don't want to bloat the image with external packages. Telegraf attempts to avoid having external package dependencies but occasionally that's not possible, as in the case of ipmitool

from influxdata-docker.

AddoSolutions avatar AddoSolutions commented on July 18, 2024

@jsternberg I agree with that, creating too big of an image would be a bummer. Do you think though that as the ipmi tools are part of the core telegraf package, that it should work?

Like, if this were some obscure plugin that one has to install, I can see that, but I would think that a core plugin to telegraf would be supported?

from influxdata-docker.

ahmedelakkad avatar ahmedelakkad commented on July 18, 2024

I'm facing the same problem, how can I add it to the docker compose?

from influxdata-docker.

jsternberg avatar jsternberg commented on July 18, 2024

I don't work at influxdata anymore and don't maintain the images, but something I've done when I need to modify an upstream image with docker compose is to do something like the following.

Add a Dockerfile somewhere in your compose structure. Since my personal thing is fairly small, I just keep it in Dockerfile but you can customize this to be anywhere you want. Here's an example of me modifying the eclipse-mosquitto image to add a custom configuration file.

FROM docker.io/library/eclipse-mosquitto AS docker.io/jsternberg/mosquitto
COPY ./mosquitto/mosquitto.conf /mosquitto/config/mosquitto.conf

Then in docker compose:

services:
  mqtt:
    image: docker.io/jsternberg/mosquitto
    build:
      target: docker.io/jsternberg/mosquitto

Whenever you make a change, you might need to do docker compose up -d --build to rebuild the image. It doesn't seem to do that automatically. If you're just doing things locally, then this should be good enough. If you're running this in a large number of places, it might be worth building the image in CI and then pulling it down so you aren't using the storage resources from the builder cache on a production machine. I think the design is you can use the same compose file for dev or production but, in production, you omit the --build flag.

from influxdata-docker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.