infobloxopen/atlas-gentool

Docker image to generate the Go source code from Protocol Buffer schemes

atlas-gentool's Issues

auto-generated code with gateway/v2 break atlas applications

Looks like we have switched tooling to gateway/v2, my ‘make protobuf’ broke as infoblox/atlas-gentool:latest emits gateway/v2 stubs. I tried to covert my app to use the new app-toolkit, it compiles but takes a run time error:

proto: extension number 1042 is already registered on message google.protobuf.FileOptions

See https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

I created a new atlas app using:

atlas init-app -gateway -pubsub -health -helm -name cost-insights-backend -registry soheileizadi -kind

I built and ran this app and it gave me the same panic message.

I debugged this problem, Proto ExtensionType being registered that throws error is:

grpc.gateway.protoc_gen_swagger.options.openapiv2_swagger

I removed the following import from my ‘service.pb.go’ auto-generated code:

_ "github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger/options"

The init of the library was registering extension that was causing the problem,
with that change I can run my application now. I am logging this with the gentool but might require additional
supporting atlas app toolkit.

Update to use new version of tools

Replace dep/glide with go modules and make sure this code generation issue is fixed in
atlas-cli:

https://github.com/infobloxopen/atlas-cli/issues/60#issuecomment-644542690

gentool image is 1.1 GB

We need to try to shrink this to as small as possible.

Support multiple architectures

Some systems like the newer MacBooks with M1 chips don't support the current images being pushed to DockerHub, and can't be built locally because of the UPX package not being present on the arm64 alpine image.

GITHUB_PATH is never defined

PROTOBUF_ARGS += -I=$(GITHUB_PATH)/vendor
/vendor: warning: directory does not exist.

I get empty fields marshalled when switching from older gentool and app-toolkit to newer tooling

Here is a sample message as seen from client from old tooling:

{"id":"EC2","aggregation":[104732,107374],"entities":{}}

Versus new tooling:

{"type":"","id":"EC2","aggregation":[69393,59305],"entities":{}}

There are many other fields emitted but just focused on the top level type field as a sample
The autogenerated code have the omit-empty option:

type Entity struct {
....

	Type          string           `protobuf:"bytes,1,opt,name=type,proto3" json:"type,omitempty"`
	Id            string           `protobuf:"bytes,2,opt,name=id,proto3" json:"id,omitempty"`
....
}

lyft/protoc-gen-validate

How do I add github.com/lyft/protoc-gen-validate ?

gentool image should include atlas-app-toolkit proto files

We want our apps to be able to reference the collection operators in their .proto files, so we should include this proto file in our image.

Atlas Gentool v21.3 Ignores lyft/proto-gen-validate Plugin rules.

While v21.2 renders validate rules rules, in 21.3 these rules are omitted.

+       // no validation rules for Name
 
-       if utf8.RuneCountInString(m.GetDescription()) > 255 {
-               return ProfileLDAPValidationError{
-                       field:  "Description",
-                       reason: "value length must be at most 255 runes",
-               }
-       }

Also, lyft has been renamed to envoyproxy, which will also cause go.mod errors if using version > 0.1.0.

Update version of grpc-gateway to 1.5.0+

allow_repeated_fields_in_body flag is introduced in version 1.5.0 of grpc-gateway, which is required to have repeated fields in the POST body

CI: docker push image takes very long ~22 minutes