ingrammicro / puzzle-tokens Goto Github PK

Batch create, manage and update Sketch styles and symbols using SCSS/LESS

License: GNU General Public License v3.0

JavaScript 81.32% CSS 0.72% Shell 0.28% Less 8.68% SCSS 8.96% Sass 0.03%

sketch-plugin less design-systems design-tokens sass css

puzzle-tokens's Issues

TypeError, plugin not working through the CLI anymore

PROCESS /Users/vincentk/Versions/ConnectApp/connect_app_atomic_library-vm.sketch
APPLY STYLES...
TypeError: undefined is not an object (evaluating 'this.pathToSource.substring')
at run (/Users/vincentk/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzleTokens.sketchplugin/Contents/Sketch/cmdline-functions.js:2007:52)
at runFromCmd (/Users/vincentk/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzleTokens.sketchplugin/Contents/Sketch/cmdline-functions.js:1979:33)
at applyStyles (/Users/vincentk/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzleTokens.sketchplugin/Contents/Sketch/cmdline-functions.js:4058:22)
at /Users/vincentk/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzleTokens.sketchplugin/Contents/Sketch/cmdline-functions.js:4131:36
at value (/Applications/Sketch.app/Contents/Resources/SketchAPI_dom.js:1:32133)
at cmdRun (/Users/vincentk/Library/Application Support/com.bohemiancoding.sketch3/Plugins/PuzzleTokens.sketchplugin/Contents/Sketch/cmdline-functions.js:4119:18){"file":"/Users/vincentk/Versions/ConnectApp/connect_app_atomic_library-vm.sketch","saveAs":"/Users/vincentk/Versions/ConnectApp/connect_app_atomic_library-sunrise.sketch","styles":"/Users/vincentk/Documents/design-assets/Sunrise/Css/Sunrise.less","commands":"apply,save,close"}

Plugin is not Running anymore after Update

HI @MaxBazarov

I get this error after updating, havent changed anything to my code, just updated sketch and your plugin?

Output in the CLI

Hi,

Did you find out what is causing this output when running PT through SketchTools?

It's not a big problem, but it makes it unclear where in the process my script is :)

Sketchtool after Sketch update crashes when running Puzzle tokens

I updated Sketch today to the latest version, and when I run my Puzzle token commands it crashes Sketchtool
Sketch Version 78 (131919)
Puzzle Tokens version: 8.17.0

Not really sure where the problem comes from :/

[FR] Text Decorations

Would love to have the possibility to add Text Decorations to a style like:
text-decoration:underline;

[FR] Paragraph space.

[FR] Separate Style Overview pages further by 'which library' the style comes from

Separate the pages further by 'which library' the style comes from, so that people using multiple libraries for different elements have them organized that way. Colors, Icons, Typo etc. and also can catch inconsistencies where styles are used from other libraries.

https://spectrum.chat/puzzle-tokens/general/guys-im-working-on-new-puzzle-tokens-feature-styles-overview-generator~adc65cb7-a14f-40ef-8615-fa8e052ca9a4?m=MTU3Mzg4MTY4MDkyNw==

No description for layer style

https://spectrum.chat/puzzle-tokens/general/guys-im-working-on-new-puzzle-tokens-feature-styles-overview-generator~adc65cb7-a14f-40ef-8615-fa8e052ca9a4?m=MTU3Mzk2NzMxNjY5OQ==

Spaces in style name

from
https://spectrum.chat/puzzle-tokens/general/documentation-of-required-attributes~7ffa350a-c423-43ee-a88a-0774d801d78a?m=MTU3NDMwNzgxODI1OA==

josh-tt
@josh1111
6:43am
I just did a test with a new file.
Create a layer in sketch called colors / black(add extra space with cursor here)
Create a style from it
Create a document in puzzle tokens with .colors .black
A new style with be created and you end up with two. So, you have to write .black__ in the scss file and look out for any extra spaces people may have used when creating styles.
Spaces at the end of a style are hard to visually identify, so I missed that one several times. If you try to find the style later, it seems that sketch corrects the space (at least in the latest version), so it looks normal in the components panel which makes it even harder to find, but in the code where sketch stores the style it must still have the space.
Edited

7:07am
Attaching an example example to test, one sec: https://drive.google.com/file/d/17_y3mg_fGzwv_KKaMdaJAMJKl7EdGscC/view?usp=sharing

7:17am
Perhaps, some sort of simple hack debugger that finds styles that are exactly the same, looking (with the exception of spaces) gives you a hint that says - "these two styles were found identically named, but have different spacings, which sketch will interpret to be a new style" would be really helpful to catch on import.
Actually, an alphabetical 2-column inventory would be really useful to debug/check things in general so you can see the old style vs new style. Spaces could be highlighted.

CLI not consequent to using the Plugin from sketch

I've made a shell script that loads a sketch fle, runs puzzle tokens from SketchTool and saves the file with another name.
Since last week when run the script, all my fles have the same .less file applied to them. instead of using different ones like before.

When I run PT from sketch everything works fine. What could be wrong?

Some way to rename loaded file Untitled.less -> given_name.less

Hey, thanks for the plugin.

There is some way to define name of the .less or .sass file that are exported with help of puzzle-tokens?

Special character in classname

Probably a bit an edge case, but maybe easy to fix?

I want to use the character Ω in the class/layer style name.
This because it is later in the alphabet, and thus later in the list.

I always get the error

Failed to parse SASS with error message:

Cannot read property 'props' of null

I guess it is not an allowed classname in css. would it be possible to fix it e.g. with the --PT- prefix?

If not also fine, then I know I need to go for another solution.

mix-blend-mode

Hi, would it be possible to use "mix-blend-mode" in this plugin in some way? If so, how?

[FR] Letter Spacing

Would love to see the letterspacing CSS property adopted. Let me know if there is any information I can provide to help with this. Thanks!

Improve error message on block comments in scss

using */block comments/* in scss gives the following error message:

It seems that these types of comments are not allowed. would be nice if there is a more helpful error message.

[FR] Implement border-styles?

https://spectrum.chat/puzzle-tokens/general/implement-border-styles~e2d7feb9-dc5b-4f8b-a8c5-aab6c5609e6a

I'm creating border variations, and have noticed that the CSS attribute "border-style" is not implemented. Is this planned? Specifically looking to implement the following border styles, in addition to the "solid" default:
dashed
dotted
double
Thanks!

Mike Bronner
@mikebronner

Plugin not working on cloud documents

ENOENT: no such file or directory, open '/Users/my-user-name/Library/Application%20Support/com.bohemiancoding.sketch3/CloudDocuments/813d2e60-b534-4276-8d04-20a31f48bb7f/puzle-tokens-text-and-layer-styles-vars.scss'

I am not 100% what goes wrong here? But it seems the in-between JSON/CSS file is not saved correctly.

A workaround, for now, is to make it a local document and then save it to the cloud manually. But ideally would like to see this fixed.

Thanks for the great plugin 👍 let me know if you need additional details.

[FR] Create opacity styles without color or other attributes.

It is beneficial to create styles that only contain opacity settings without any other attributes. This would allow us to apply them to groups and other containers as a whole.

I attempted this, but the plugin doesn't seem to create the styles correctly. I tried both decimal and percentage values.

.Opacities .0 {
  opacity: 0;
}
.Opacities .25 {
  opacity: 0.25;
}
.Opacities .50 {
  opacity: 0.5;
}
.Opacities .75 {
  opacity: 0.75;
}
.Opacities .100 {
  opacity: 1;
}

[FR] Multiple Box-Shadow Properties

Trying to get multiple shadows properties to work but it doesn't seem to work.

For example:
background: rgba(255,255,255,0.00);
box-shadow: 0 7px 40px 0 rgba(0,0,0,0.13), 0 2px 8px 0 rgba(0,0,0,0.24);
border-radius: 4px;

Is this currently supported in the plugin?

Getting errors trying to run LESS styles.

Started
Read LESS: running...
/usr/local/lib/node_modules/less
internal/modules/cjs/loader.js:797
    throw err;
    ^

Error: Cannot find module '/usr/local/lib/node_modules/less'
Require stack:
- /private/var/folders/k8/vy_1t24s075cnqhjpy2f6qx80000gn/T/nsconvert_less.js
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:794:15)
    at Function.Module._load (internal/modules/cjs/loader.js:687:27)
    at Module.require (internal/modules/cjs/loader.js:849:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at transformLESStoJSON (/private/var/folders/k8/vy_1t24s075cnqhjpy2f6qx80000gn/T/nsconvert_less.js:96:16)
    at Object.<anonymous> (/private/var/folders/k8/vy_1t24s075cnqhjpy2f6qx80000gn/T/nsconvert_less.js:27:1)
    at Module._compile (internal/modules/cjs/loader.js:956:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
    at Module.load (internal/modules/cjs/loader.js:812:32)
    at Function.Module._load (internal/modules/cjs/loader.js:724:14) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/private/var/folders/k8/vy_1t24s075cnqhjpy2f6qx80000gn/T/nsconvert_less.js'
  ]
}

Less is installed:

which less
/usr/bin/less

Any suggestions? Thanks!

Generate Style Overview - Bug

Love the new Generate Style Overview feature in the latest release. When I generated the style, I did noticed that it added two extra characters to the Hex value as well as a border color to the label text. https://drive.google.com/file/d/1WQ9nrBDClYtKZj40pOrfpOZ7nFisafPB

uppercase
lowercase
capitalize (this doesn't appear to be supported in Sketch?)
none

I am using macOS Mojave and the latest sketch 66.1

(I'll try to upload a screenshot later, firewall restrictions atm.)

ingrammicro / puzzle-tokens Goto Github PK

puzzle-tokens's Issues

Recommend Projects

Recommend Topics

Recommend Org