inpsyde/filter

Inpsyde Filter library.

filter's Issues

Inherited `@uses` documentation

Each filter class's filter() method aims to inherit the docs from the AbstractFilter class's abstract filter() method.

However, not all of the filter classes use _doing_it_wrong() as the @uses suggests.

Replacing Exceptions with `_doing_it_wrong`

Since this package is designed to fit into a WordPress-envoirment, Exceptions could lead to broken sites (WordPress does not handle Exceptions by default).

Exception in set_options
Maybe we should change the behavior of set_options from throwing an InvalidArgumentException to a more "wordpressy"-way by using _doing_it_wrong() and not setting the given configuration to the $options-array.

Usage of _doing_it_wrong in Inpsyde\Filter\WordPress
The other point which has to be discussed is the _doing_it_wrong in Inpsyde\Filter\WordPress folder, when a incorrect $value-type is given. I think just returning the value and triggering a _doing_it_wrong seems to be ok, since WordPress does nothing (no error message, just continue with something similar or even break) against wrong values.

[Question] What is the idea behind mutable filter objects?

Just this question to get the idea behind this approach. The mutable state means that a filter object can return different values for the same argument during its life cycle. Further any user of the filter would be able to change the behavior of the filter. Is that desired?