inseefr/btb

An R package which provides functions dedicated to urban analysis and kernel density estimation.

btb's Issues

replace cartography by mapsf

I suggest to replace cartography by mapsf in examples.
See: https://github.com/riatelab/cartography#consider-mapsf
Would you be interested by a PR?

Invalid URLs in vignette

Hi,
While checking the package I get :

Found the following (possibly) invalid URLs:
  URL: http://r.iresmi.net/2019/05/11/kernel-spatial-smoothing-transforming-points-pattern-to-continuous-coverage/ (moved to https://r.iresmi.net/posts/2019/kernel_spatial_smoothing_transforming_points_pattern_to_continuous_coverage/)
    From: inst/doc/btb.html
    Status: 200
    Message: OK
  URL: https://githubmemory.com/repo/SNStatComp/awesome-official-statistics-software
    From: inst/doc/btb.html
    Status: Error
    Message: libcurl error code 7:
      	Failed to connect to githubmemory.com port 443 after 111 ms: Couldn't connect to server
  URL: https://inspire.ec.europa.eu/ (moved to https://knowledge-base.inspire.ec.europa.eu/index_en)
    From: inst/doc/btb.html
    Status: 200
    Message: OK
  URL: https://mobile.twitter.com/DavidZumbach/status/1373166163497213952
    From: inst/doc/btb.html
    Status: 403
    Message: Forbidden
  URL: https://mobile.twitter.com/raffverduzco/status/1128075094524350464?lang=bg
    From: inst/doc/btb.html
    Status: 403
    Message: Forbidden

(for the last 2, Twitter is no longer accessible without an user account)

Error: sEPSG not valid

Hello,

On line 177 of btb_smooth.R, you check that the length of the sEPSG argument is equal to 4 characters when the function is provided with a sf object:

stopifnot("sEPSG not valid "= identical(nchar(as.character(sEPSG)),4L))

However, the epsg code could be of a length greater than 4 character. You have such an instance in the second example that you provide:

 # Example 2
 data(reunion)
 # Call mode 1: classic smoothing - automatic grid
 reunionSmoothed <- btb_smooth( pts = reunion,
                                     sEPSG = "32740",
                                     iCellSize = 200L,
                                     iBandwidth = 400L)

reunion is a data.frame, but if you transform it to a sf object and try to run the code, it errors:

 # Example 2
 data(reunion)
reunion <- sf::st_as_sf(reunion, coords = c("x","y"), crs = 32740)
 # Call mode 1: classic smoothing - automatic grid
 reunionSmoothed <- btb_smooth( pts = reunion,
                                     iCellSize = 200L,
                                     iBandwidth = 400L)
Error in btb_smooth(pts = reunion, iCellSize = 200L, iBandwidth = 400L) : 
  sEPSG not valid 

Is there a reason I am not understanding for the check for a epsg length equal to 4?

Thank you, and thank you for your very useful package!