inseefr/pogues

Questionnaire designer

pogues's Issues

Server API not using the right MIME types

text/plain is used for persistence API and text/html for publish API.
Both should use application/json.

Jetty - CORS - Response headers

No success with working on Jetty configuration (web.xml) with things like :

 <filter>
   <filter-name>cross-origin</filter-name>
   <filter-class>org.eclipse.jetty.servlets.CrossOriginFilter</filter-class>
   <init-param>
       <param-name>allowedOrigins</param-name>
       <param-value>*</param-value>
   </init-param>
   <init-param>
       <param-name>allowedMethods</param-name>
       <param-value>*</param-value>
   </init-param>
   <init-param>
       <param-name>allowedHeaders</param-name>
       <param-value>Location</param-value>
   </init-param>
 </filter>
 <filter-mapping>
     <filter-name>cross-origin</filter-name>
     <filter-pattern>/*</filter-pattern>
 </filter-mapping>

(wildcard doesn't seem to be allowed for param-value of allowedHeaders).

So we explicit set some headers when we build the response (XQuery) :

Access-Control-Allow-Headers:Location, Content-Type
Access-Control-Expose-Headers:Location, Content-Type

(I guess only one of these is useful, but we didn't have time to check which one).

Include 'vendor' folder in build

Implement SequenceModel.append(child, depth)

Required in particular by GenericInput.
The method should append a question or sequence to an existing sequence, at a given depth. If depth is 1, the method is equivalent to addChild(child). For depth = 2, it is addChild(child) on the last direct child, etc.

Drag and drop support in questionnaire outlook

Add the possibility to change component ordering by drag and drop in the questionnaire outlook.

See for example https://reactjsnews.com/complex-drag-and-drop-lists-using-react/

Synchronisation between questionnaire outlook and questionnaire

Questionnaire outlook should be sticky, and a click on a component should scroll the main panel to that component.

Define color guide

See http://purple.herokuapp.com/, https://www.firebase.com/docs/styleguide.html, http://primercss.io/, or more generally http://www.thoughtworks.com/radar/techniques/living-css-style-guides

Problem with caracter "dash"

When writing a caracter "dash" in the label of a sequence, the input field is empty

Design edit mode of Sequence

Should allow to:

• Modify sequence name
• delete children sequences or questions
• add, modify or delete declarations and controls

Define server API

First proposal:

• http://[authority]/pogues/questionnaires
  • GET questionnaire list
  • PUT questionnaire list
  • POST create new questionnaire (returns questionnaire URI with created id)
• http://[authority]/pogues/questionnaire/{id}
  • GET questionnaire
  • PUT questionnaire

Define documentation methods

What tools to use to document the JS programs?

Suggest visualizationHint only for the codeList

Don't suggest visualizationHint if a codeList is not selected

Design main menu

Define functionalities and corresponding icons.

Enforcing use of PropTypes in component

We could make use of React prop validation to list the props used by a component. See https://facebook.github.io/react/docs/reusable-components.html#prop-validation.

Cannot publish any Questionnare

The last questionnaire published was on friday the 17th.

Clarify API methods naming

Use 'get' instead of 'load'.

Implement search

Associated to the search box in the general menu.

First level questions are store in the questionnaire at the same level that sequence owner

The culprit seems to be the way we use the appendComponent in the QuestionnaireStore : we always append sequences and questions to the questionnaire itself, where we should append the questions to the sequence their belong to.

Normalise spacing in files

Not uniform in all files, sometimes it's a tab sometimes two whitespaces.

Make use of a linter

http://eslint.org/ seems to be the right choice.

Syncrhonisation issue in Gulp with babel and browserify

I tried to remove es6 compiled files from tracked files, but gulp build fails when I run build after deleting src/js/models/*.js files. If I run gulp build:es6transpile and then gulp build again, it works.
I tried to ensure that babel was done before running browserify, using runSequence, but I didn't managed to make it work. Without any change, the build process seems to work, but I guess sometimes we can miss some changes made to the models since the last compilation.

Here's a way of doing it in a different way : https://github.com/BrowserSync/recipes/tree/master/recipes/gulp.browserify

Refactor logging

Finish data model

Hook with Gitter

No declaration in the generated questionnaire

I created declaration(s) in "'Pogues", but no declaration appears in the generated questionnaire

Enhance GenericInput

• Tab change with color code
• Depth arrow for sequences
• Type of component icons

'Component' React component

• create component
• render
  • <+>
  • if question,
  • else

Outlook enhancement

• refactor rendering
• drag and drop
• add menu (including search)
• synchronisation

Fix default build

'default' gulp task runs 'browserify', which calls 'del:dist'. When it is completed, css and img folders are gone.

Problem with React state

When selecting a questionnaire, going back to the list and reselecting.

Specify how we configure the application

Do we just load a JSON file? are there some standard ways of doing this?

Fix keyboard shortcuts in GenericInput

File naming convention

We have some of "my-file.js" and "MyFile.js". It will be clearer if we choose a one or the other form.

Display the label of a list of codes ?

to generate the array of SOeS, can we manage a concept of "Display the label of a liste of codes" (type boolean)

Name of the sequence instead of the label

The name of the sequence is displayed in the questionnaire generated instead of the label

Problem with 'Component' component

For the rendering of the questionnaire, we have React components 'Component', 'Sequence' and 'Question' mapping the corresponding model classes. Component is a superclass of Sequence and Question.

When structuring the rendering as Sequence -> Component -> Sequence or Question (see commit 333b1e8), the rendering bugs when there are sequences of depth 2 (ie sequences that are nested in others).

We have messages like: 'Warning: Only functions of strings can be mounted as React components', often followed by 'TypeError: element.type is not a constructor', and the questionnaire is not rendered at all.

Changing the rendering structure to Sequence -> Sequence or Question (see commit cd38356) seems to solve the problem.

Wouldn't it be cool to have remote logging ?

A simple suggestion : to have a logging lib, that can switch between a local/dev mode (that logs on the client via console), and a remote/prod mode (that push asynchronously log statements to a remote API).

What do you think guys ?

Save instruction type

Instruction type is not saved in Pogue

Build task should also copy img directory

Improve internationalization

Manage app state

I think it could be time to think about managing global state in a consistent way and considering using a router solution.

Display a list of codes in the generated questionnaire

The list of codes doesn't exist in the generated questionnaire. Perhaps a similar problem than issue #47 ?

Add "Warning" in "DeclarationTypeEnum"

Proposal to add value "Warning" in the enumaration "DeclarationTypeEnum"

Integrate data model

• in the stores
• in the React components
• in the API

Questionnaire outlook rendering enhancement

Render all components and improve visual design

Create server test data

Create two questionnaires corresponding to the Pogues XML schema (LFS + crash test questionnaire), and make them available on the database server according to the Server API (issue #20).

Design edit mode of Question

Should allow to:

• change question name
• change response characteristics
• add, modify or delete declarations and controls (common with #23)

Numeric response doesn't work in the generated questionnaire

Minimum & maximum of a numeric response doesn't exist in the generated questionnaire

Document the architecture

On the wiki

Implementation of heritage in Babel

Firefox console shows messages like:

mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create

See also http://stackoverflow.com/a/28693578 and links in answers.